tune CI metrics configs

Author: vaind

packages/replay/metrics/configs/ci/collect.ts

@@ -39,6 +39,7 @@ const result = await collector.execute({
 
     const cpuUsage = stats.mean(MetricsStats.cpu)!;
     if (cpuUsage > 0.85) {
+      // Note: complexity on the "JankTest" is defined by the `minimum = ...,` setting in app.js - specifying the number of animated elements.
       console.warn(`✗ | Discarding results because CPU usage is too high and may be inaccurate: ${(cpuUsage * 100).toFixed(2)} %.`,
         'Consider simplifying the scenario or changing the CPU throttling factor.');
       return false;

packages/replay/metrics/src/results/analyzer.ts

@@ -83,16 +83,16 @@ class AnalyzerItemNumberValue implements AnalyzerItemValue {
 
   public get diff(): string {
     const diff = this._b - this._a;
-    const str = this._withUnit(diff);
+    const str = this._withUnit(diff, true);
     return diff > 0 ? `+${str}` : str;
   }
 
-  private _withUnit(value: number): string {
+  private _withUnit(value: number, isDiff: boolean = false): string {
     switch (this._unit) {
       case AnalyzerItemUnit.bytes:
         return filesize(value) as string;
       case AnalyzerItemUnit.ratio:
-        return `${(value * 100).toFixed(2)} %`;
+        return `${(value * 100).toFixed(2)} ${isDiff ? 'pp' : '%'}`;
       default:
         return `${value.toFixed(2)} ${AnalyzerItemUnit[this._unit]}`;
     }

packages/replay/metrics/src/results/pr-comment.ts

@@ -4,7 +4,7 @@ import { Result } from './result.js';
 import { ResultSetItem } from './results-set.js';
 
 function trimIndent(str: string): string {
-  return str.split('\n').map(s => s.trim()).join('\n');
+  return str.trim().split('\n').map(s => s.trim()).join('\n');
 }
 
 function printableMetricName(metric: AnalyzerItemMetric): string {
@@ -32,7 +32,15 @@ export class PrCommentBuilder {
   }
 
   public get body(): string {
-    return trimIndent(this._buffer);
+    const now = new Date();
+    return trimIndent(`
+      ${this._buffer}
+      <hr />
+      <div align="right">
+        CPU usage difference is shown as <a href="https://en.wikipedia.org/wiki/Percentage_point">percentage points</a>. <br />
+        Last updated: <time datetime="${now.toISOString()}">${now.toUTCString()}</time>
+      </div>
+    `);
   }
 
   public async addCurrentResult(analysis: Analysis, otherName: string): Promise<void> {

packages/replay/metrics/test-apps/jank/app.js

@@ -25,7 +25,7 @@ document.addEventListener("DOMContentLoaded", function() {
       incrementor = 10,
       distance = 3,
       frame,
-      minimum = 30,
+      minimum = 70,
       subtract = document.querySelector('.subtract'),
       add = document.querySelector('.add');