fix(core): Fix replay client report data category (#6891)

Author: mydea

packages/core/src/baseclient.ts

@@ -504,10 +504,12 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
       );
     }
 
+    const dataCategory: DataCategory = eventType === 'replay_event' ? 'replay' : eventType;
+
     return this._prepareEvent(event, hint, scope)
       .then(prepared => {
         if (prepared === null) {
-          this.recordDroppedEvent('event_processor', eventType, event);
+          this.recordDroppedEvent('event_processor', dataCategory, event);
           throw new SentryError('An event processor returned `null`, will not send event.', 'log');
         }
 
@@ -521,7 +523,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
       })
       .then(processedEvent => {
         if (processedEvent === null) {
-          this.recordDroppedEvent('before_send', event.type || 'error', event);
+          this.recordDroppedEvent('before_send', dataCategory, event);
           throw new SentryError(`${beforeSendLabel} returned \`null\`, will not send event.`, 'log');
         }
 

packages/replay/src/util/sendReplayRequest.ts

@@ -58,7 +58,7 @@ export async function sendReplayRequest({
 
   if (!replayEvent) {
     // Taken from baseclient's `_processEvent` method, where this is handled for errors/transactions
-    client.recordDroppedEvent('event_processor', 'replay_event', baseEvent);
+    client.recordDroppedEvent('event_processor', 'replay', baseEvent);
     __DEBUG_BUILD__ && logger.log('An event processor returned `null`, will not send event.');
     return;
   }

packages/types/src/datacategory.ts

@@ -11,7 +11,7 @@ export type DataCategory =
   // Transaction type event
   | 'transaction'
   // Replay type event
-  | 'replay_event'
+  | 'replay'
   // Events with `event_type` csp, hpkp, expectct, expectstaple
   | 'security'
   // Attachment bytes stored (unused for rate limiting
@@ -21,7 +21,4 @@ export type DataCategory =
   // SDK internal event, like client_reports
   | 'internal'
   // Profile event type
-  | 'profile'
-  // Replay event types
-  | 'replay_event'
-  | 'replay_recording';
+  | 'profile';

packages/utils/src/envelope.ts

@@ -190,8 +190,8 @@ const ITEM_TYPE_TO_DATA_CATEGORY_MAP: Record<EnvelopeItemType, DataCategory> = {
   client_report: 'internal',
   user_report: 'default',
   profile: 'profile',
-  replay_event: 'replay_event',
-  replay_recording: 'replay_recording',
+  replay_event: 'replay',
+  replay_recording: 'replay',
 };
 
 /**