remove remaining tslint references

Author: AbhiPrasad

.eslintrc.js

@@ -87,6 +87,12 @@ module.exports = {
         'simple-import-sort/sort': 'error',
         'sort-imports': 'off',
         'import/order': 'off',
+
+        // Disallow delete operator. We should make this operation opt in (by disabling this rule).
+        '@typescript-eslint/no-dynamic-delete': 'error',
+
+        // We should prevent against overloads unless necessary.
+        '@typescript-eslint/unified-signatures': 'error',
       },
     },
     {
@@ -102,6 +108,9 @@ module.exports = {
           'error',
           { require: { ClassDeclaration: true, MethodDefinition: true }, checkConstructors: false },
         ],
+
+        // All imports should be accounted for
+        'import/no-extraneous-dependencies': 'error',
       },
     },
     {
@@ -164,5 +173,8 @@ module.exports = {
 
     // imports should be ordered.
     'import/order': ['error', { 'newlines-between': 'always' }],
+
+    // Make sure for in loops check for properties
+    'guard-for-in': 'error',
   },
 };

.vscode/extensions.json

@@ -1,5 +1,5 @@
 {
   // See http://go.microsoft.com/fwlink/?LinkId=827846
   // for the documentation about the extensions.json format
-  "recommendations": ["esbenp.prettier-vscode", "ms-vscode.vscode-typescript-tslint-plugin", "dbaeumer.vscode-eslint"]
+  "recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"]
 }

.vscode/settings.json

@@ -13,7 +13,6 @@
     "**/dist/": true
   },
   "typescript.tsdk": "./node_modules/typescript/lib",
-  "tslint.autoFixOnSave": true,
   "[json]": {
     "editor.formatOnType": false,
     "editor.formatOnPaste": false,

package.json

@@ -43,8 +43,8 @@
     "@types/mocha": "^5.2.0",
     "@types/node": "^11.13.7",
     "@types/sinon": "^7.0.11",
-    "@typescript-eslint/eslint-plugin": "^3.7.1",
-    "@typescript-eslint/parser": "^3.7.1",
+    "@typescript-eslint/eslint-plugin": "^3.9.0",
+    "@typescript-eslint/parser": "^3.9.0",
     "chai": "^4.1.2",
     "codecov": "^3.6.5",
     "danger": "^7.1.3",
@@ -68,10 +68,8 @@
     "sinon": "^7.3.2",
     "size-limit": "^4.5.5",
     "ts-jest": "^24.0.2",
-    "tslint": "5.16.0",
     "typedoc": "^0.14.2",
-    "typescript": "3.4.5",
-    "typescript-tslint-plugin": "^0.3.1"
+    "typescript": "3.4.5"
   },
   "resolutions": {
     "**/agent-base": "5"

packages/angular/package.json

@@ -30,7 +30,6 @@
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
     "rimraf": "^2.6.3",
-    "tslint": "^5.16.0",
     "typescript": "^3.5.1"
   },
   "scripts": {

packages/angular/src/errorhandler.ts

@@ -78,7 +78,6 @@ class SentryErrorHandler implements AngularErrorHandler {
     // Allow custom overrides of extracting function
     if (this._options.extractor) {
       const defaultExtractor = this._defaultExtractor.bind(this);
-      // tslint:disable-next-line:no-unsafe-any
       return this._options.extractor(error, defaultExtractor);
     }
 

packages/angular/src/tracing.ts

@@ -148,7 +148,6 @@ export function TraceClassDecorator(): ClassDecorator {
 
   // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
   return target => {
-    // tslint:disable-next-line:no-unsafe-any
     const originalOnInit = target.prototype.ngOnInit;
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     target.prototype.ngOnInit = function(...args: any[]): ReturnType<typeof originalOnInit> {
@@ -171,7 +170,6 @@ export function TraceClassDecorator(): ClassDecorator {
         tracingSpan.finish();
       }
       if (originalAfterViewInit) {
-        // tslint:disable-next-line:no-unsafe-any
         return originalAfterViewInit.apply(this, args);
       }
     };
@@ -198,7 +196,6 @@ export function TraceMethodDecorator(): MethodDecorator {
         });
       }
       if (originalMethod) {
-        // tslint:disable-next-line:no-unsafe-any
         return originalMethod.apply(this, args);
       }
     };

packages/apm/package.json

@@ -36,7 +36,6 @@
     "rollup-plugin-node-resolve": "^4.2.3",
     "rollup-plugin-terser": "^4.0.4",
     "rollup-plugin-typescript2": "^0.21.0",
-    "tslint": "5.16.0",
     "typescript": "3.4.5"
   },
   "scripts": {

packages/apm/src/index.bundle.ts

@@ -61,12 +61,10 @@ export { Span, TRACEPARENT_REGEXP } from './span';
 let windowIntegrations = {};
 
 // This block is needed to add compatibility with the integrations packages when used with a CDN
-// tslint:disable: no-unsafe-any
 const _window = getGlobalObject<Window>();
 if (_window.Sentry && _window.Sentry.Integrations) {
   windowIntegrations = _window.Sentry.Integrations;
 }
-// tslint:enable: no-unsafe-any
 
 const INTEGRATIONS = {
   ...windowIntegrations,

packages/apm/src/integrations/tracing.ts

@@ -315,7 +315,7 @@ export class Tracing implements Integration {
         }
         span.finish();
       }
-      // tslint:disable-next-line: no-dynamic-delete
+      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
       delete Tracing._activities[id];
     }
 
@@ -698,7 +698,6 @@ export class Tracing implements Integration {
     }
 
     Tracing._performanceCursor = Math.max(performance.getEntries().length - 1, 0);
-    // tslint:enable: no-unsafe-any
   }
 
   /**
@@ -792,7 +791,6 @@ export class Tracing implements Integration {
     }
     debugData['Date.now()'] = Date.now();
     span.setData('sentry_debug', debugData);
-    // tslint:enable: no-unsafe-any
   }
 
   /**
@@ -945,12 +943,10 @@ function xhrCallback(handlerData: { [key: string]: any }): void {
     return;
   }
 
-  // tslint:disable-next-line: no-unsafe-any
   if (!handlerData || !handlerData.xhr || !handlerData.xhr.__sentry_xhr__) {
     return;
   }
 
-  // tslint:disable: no-unsafe-any
   const xhr = handlerData.xhr.__sentry_xhr__;
 
   if (!Tracing.options.shouldCreateSpanForRequest(xhr.url)) {
@@ -988,15 +984,13 @@ function xhrCallback(handlerData: { [key: string]: any }): void {
       }
     }
   }
-  // tslint:enable: no-unsafe-any
 }
 
 /**
  * Creates breadcrumbs from fetch API calls
  */
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function fetchCallback(handlerData: { [key: string]: any }): void {
-  // tslint:disable: no-unsafe-any
   if (!Tracing.options.traceFetch) {
     return;
   }
@@ -1043,7 +1037,6 @@ function fetchCallback(handlerData: { [key: string]: any }): void {
       }
     }
   }
-  // tslint:enable: no-unsafe-any
 }
 
 /**