review comments

Author: s1gr1d

dev-packages/browser-integration-tests/utils/generatePlugin.ts

@@ -129,17 +129,14 @@ function generateSentryAlias(): Record<string, string> {
 
   return Object.fromEntries(
     packageNames.map(packageName => {
-      // pluggable integrations exist in the browser package
-      const actPackageName = packageName === 'integrations' ? 'browser' : packageName;
-
       const packageJSON: Package = JSON.parse(
-        fs.readFileSync(path.resolve(PACKAGES_DIR, actPackageName, 'package.json'), { encoding: 'utf-8' }).toString(),
+        fs.readFileSync(path.resolve(PACKAGES_DIR, packageName, 'package.json'), { encoding: 'utf-8' }).toString(),
       );
 
-      const modulePath = path.resolve(PACKAGES_DIR, actPackageName);
+      const modulePath = path.resolve(PACKAGES_DIR, packageName);
 
-      if (useCompiledModule && bundleKey && BUNDLE_PATHS[actPackageName]?.[bundleKey]) {
-        const bundlePath = path.resolve(modulePath, BUNDLE_PATHS[actPackageName][bundleKey]);
+      if (useCompiledModule && bundleKey && BUNDLE_PATHS[packageName]?.[bundleKey]) {
+        const bundlePath = path.resolve(modulePath, BUNDLE_PATHS[packageName][bundleKey]);
 
         return [packageJSON['name'], bundlePath];
       }

dev-packages/rollup-utils/bundleHelpers.mjs

@@ -59,7 +59,7 @@ export function makeBaseBundleConfig(options) {
     plugins: [rrwebBuildPlugin, markAsBrowserBuildPlugin],
   };
 
-  // used by `@sentry/wasm` (bundles which need to be combined with a stand-alone SDK bundle)
+  // used by `@sentry/wasm` & pluggable integrations from core/browser (bundles which need to be combined with a stand-alone SDK bundle)
   const addOnBundleConfig = {
     // These output settings are designed to mimic an IIFE. We don't use Rollup's `iife` format because we don't want to
     // attach this code to a new global variable, but rather inject it into the existing SDK's `Integrations` object.

packages/browser/rollup.bundle.config.mjs

@@ -8,7 +8,7 @@ if (targets.some(target => target !== 'es5' && target !== 'es6')) {
   throw new Error('JS_VERSION must be either "es5" or "es6"');
 }
 
-const addonIntegrationFiles = ['contextlines', 'httpclient', 'reportingobserver'];
+const browserPluggableIntegrationFiles = ['contextlines', 'httpclient', 'reportingobserver'];
 
 const coreIntegrationFiles = ['captureconsole', 'debug', 'dedupe', 'extraerrordata', 'rewriteframes', 'sessiontiming'];
 
@@ -29,7 +29,7 @@ targets.forEach(jsVersion => {
     outputFileBase: () => `bundles/bundle.tracing${jsVersion === 'es5' ? '.es5' : ''}`,
   });
 
-  addonIntegrationFiles.forEach(integrationName => {
+  browserPluggableIntegrationFiles.forEach(integrationName => {
     const integrationsBundleConfig = makeBaseBundleConfig({
       bundleType: 'addon',
       entrypoints: [`src/integrations/${integrationName}.ts`],