build: Remove dom types from main tsconfig

AbhiPrasad · AbhiPrasad · commit 81b0341588cf · 2024-07-09T18:06:51.000-04:00
diff --git a/dev-packages/node-integration-tests/tsconfig.test.json b/dev-packages/node-integration-tests/tsconfig.test.json
@@ -4,6 +4,9 @@
   "include": ["suites/**/*.ts"],
 
   "compilerOptions": {
+    // Although this seems wrong to include `DOM` here, it's necessary to make
+    // global fetch available in tests in lower Node versions.
+    "lib": ["DOM", "ES2018"],
     // should include all types from `./tsconfig.json` plus types for all test frameworks used
     "types": ["node", "jest"]
 
diff --git a/packages/angular/tsconfig.ngc.json b/packages/angular/tsconfig.ngc.json
@@ -7,7 +7,7 @@
   "compilerOptions": {
     "target": "es2018",
     "declarationMap": false,
-    "lib": ["dom", "es2018"],
+    "lib": ["DOM", "ES2018"],
     "baseUrl": "./"
   },
   "angularCompilerOptions": {
diff --git a/packages/browser-utils/tsconfig.json b/packages/browser-utils/tsconfig.json
@@ -4,6 +4,6 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    // package-specific options
+    "lib": ["DOM", "ES2018"],
   }
 }
diff --git a/packages/browser/tsconfig.json b/packages/browser/tsconfig.json
@@ -4,6 +4,6 @@
   "include": ["src/**/*", "test/loader.js"],
 
   "compilerOptions": {
-    // package-specific options
+    "lib": ["DOM", "ES2018"],
   }
 }
diff --git a/packages/core/tsconfig.test.json b/packages/core/tsconfig.test.json
@@ -4,6 +4,7 @@
   "include": ["test/**/*"],
 
   "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
     // should include all types from `./tsconfig.json` plus types for all test frameworks used
     "types": ["node", "jest"]
 
diff --git a/packages/ember/tsconfig.json b/packages/ember/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "target": "es2022",
+    "lib": ["DOM", "ES2022"],
     "allowJs": true,
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,
diff --git a/packages/gatsby/tsconfig.json b/packages/gatsby/tsconfig.json
@@ -4,6 +4,7 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
     // package-specific options
     "jsx": "react"
   }
diff --git a/packages/react/tsconfig.json b/packages/react/tsconfig.json
@@ -4,6 +4,7 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
     // package-specific options
     "esModuleInterop": true,
     "jsx": "react"
diff --git a/packages/remix/tsconfig.test.json b/packages/remix/tsconfig.test.json
@@ -4,6 +4,7 @@
   "include": ["test/**/*", "vitest.config.ts"],
 
   "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
     "types": ["node", "jest"],
     "esModuleInterop": true
   }
diff --git a/packages/replay-canvas/tsconfig.json b/packages/replay-canvas/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
     "module": "esnext"
   },
   "include": ["src/**/*.ts"]
diff --git a/packages/replay-canvas/tsconfig.test.json b/packages/replay-canvas/tsconfig.test.json
@@ -4,6 +4,7 @@
   "include": ["test/**/*.ts", "jest.config.ts", "jest.setup.ts"],
 
   "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
     "types": ["node", "jest"],
     "esModuleInterop": true,
     "allowJs": true,
diff --git a/packages/replay-internal/tsconfig.json b/packages/replay-internal/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
     "module": "esnext"
   },
   "include": ["src/**/*.ts"]
diff --git a/packages/solid/tsconfig.json b/packages/solid/tsconfig.json
@@ -3,5 +3,7 @@
 
   "include": ["src/**/*"],
 
-  "compilerOptions": {}
+  "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
+  }
 }
diff --git a/packages/svelte/tsconfig.json b/packages/svelte/tsconfig.json
@@ -3,5 +3,7 @@
 
   "include": ["src/**/*"],
 
-  "compilerOptions": {}
+  "compilerOptions": {
+    "lib": ["DOM", "ES2018"],
+  }
 }
diff --git a/packages/typescript/tsconfig.json b/packages/typescript/tsconfig.json
@@ -7,7 +7,7 @@
     "importHelpers": true,
     "inlineSources": true,
     "isolatedModules": true,
-    "lib": ["es2018", "dom"],
+    "lib": ["ES2018"],
     "moduleResolution": "node",
     "noErrorTruncation": true,
     "noFallthroughCasesInSwitch": true,
diff --git a/packages/vercel-edge/tsconfig.json b/packages/vercel-edge/tsconfig.json
@@ -4,7 +4,10 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    // package-specific options
+    // Note: using `dom` here is inaccurate for the vercel-edge runtime, but needed
+    // because @edge-runtime/types does not type things like fetch or RequestInit
+    // ref: https://github.com/vercel/edge-runtime/issues/506
+    "lib": ["DOM", "ES2018"],
     "types": ["@edge-runtime/types"]
   }
 }
diff --git a/packages/vue/tsconfig.json b/packages/vue/tsconfig.json
@@ -4,6 +4,6 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    // package-specific options
+    "lib": ["DOM", "ES2018"],
   }
 }
diff --git a/packages/wasm/tsconfig.json b/packages/wasm/tsconfig.json
@@ -4,6 +4,6 @@
   "include": ["src/**/*"],
 
   "compilerOptions": {
-    // package-specific options
+    "lib": ["DOM", "ES2018"],
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"include": ["src/*/"],`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
`7`		`- // package-specific options`
	`7`	`+ "lib": ["DOM", "ES2018"],`
`8`	`8`	`}`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"include": ["src/*/", "test/loader.js"],`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
`7`		`- // package-specific options`
	`7`	`+ "lib": ["DOM", "ES2018"],`
`8`	`8`	`}`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`"include": ["src/*/"],`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
	`7`	`+ "lib": ["DOM", "ES2018"],`
`7`	`8`	`// package-specific options`
`8`	`9`	`"jsx": "react"`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`"include": ["test/*/", "vitest.config.ts"],`
`5`	`5`
`6`	`6`	`"compilerOptions": {`
	`7`	`+ "lib": ["DOM", "ES2018"],`
`7`	`8`	`"types": ["node", "jest"],`
`8`	`9`	`"esModuleInterop": true`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.json",`
`3`	`3`	`"compilerOptions": {`
	`4`	`+ "lib": ["DOM", "ES2018"],`
`4`	`5`	`"module": "esnext"`
`5`	`6`	`},`
`6`	`7`	`"include": ["src/*/.ts"]`