always return the active transaction, even if sampled = false

Author: lobsterkatie

packages/hub/src/scope.ts

@@ -217,11 +217,7 @@ export class Scope implements ScopeInterface {
    * @inheritDoc
    */
   public getTransaction(): Transaction | undefined {
-    const span = this.getSpan() as Span & { spanRecorder: { spans: Span[] } };
-    if (span && span.spanRecorder && span.spanRecorder.spans[0]) {
-      return span.spanRecorder.spans[0] as Transaction;
-    }
-    return undefined;
+    return this.getSpan() as Transaction;
   }
 
   /**

packages/tracing/test/hub.test.ts

@@ -23,9 +23,23 @@ describe('Hub', () => {
   });
 
   describe('getTransaction()', () => {
-    it('should find a transaction which has been set on the scope', () => {
+    it('should find a transaction which has been set on the scope if sampled = true', () => {
       const hub = new Hub(new BrowserClient({ tracesSampleRate: 1 }));
       const transaction = hub.startTransaction({ name: 'dogpark' });
+      transaction.sampled = true;
+
+      hub.configureScope(scope => {
+        scope.setSpan(transaction);
+      });
+
+      expect(hub.getScope()?.getTransaction()).toBe(transaction);
+    });
+
+    it('should find a transaction which has been set on the scope if sampled = false', () => {
+      const hub = new Hub(new BrowserClient({ tracesSampleRate: 1 }));
+      const transaction = hub.startTransaction({ name: 'dogpark' });
+      transaction.sampled = false;
+
       hub.configureScope(scope => {
         scope.setSpan(transaction);
       });