ref(core): Streamline module_metadata assignment and cleanup functions (#17696)

Quick PR to streamline the stack frame `module_metadata` property
assignment (`addMetadataToStackFrames`) and cleanup
(`stripMetadataFromStackFrames`) logic, since we can use optional
chaining now without a bundle size hit from polyfilling.

Originally went with moving the cleanup logic into the client but
decided against it due to the bundle size hit (see comment).

Author: Lms24

packages/core/src/index.ts

@@ -101,7 +101,7 @@ export { functionToStringIntegration } from './integrations/functiontostring';
 export { inboundFiltersIntegration } from './integrations/eventFilters';
 export { eventFiltersIntegration } from './integrations/eventFilters';
 export { linkedErrorsIntegration } from './integrations/linkederrors';
-export { moduleMetadataIntegration } from './integrations/metadata';
+export { moduleMetadataIntegration } from './integrations/moduleMetadata';
 export { requestDataIntegration } from './integrations/requestdata';
 export { captureConsoleIntegration } from './integrations/captureconsole';
 export { dedupeIntegration } from './integrations/dedupe';

packages/core/src/integrations/metadata.ts renamed to packages/core/src/integrations/moduleMetadata.ts

@@ -42,7 +42,6 @@ export const thirdPartyErrorFilterIntegration = defineIntegration((options: Opti
     name: 'ThirdPartyErrorsFilter',
     setup(client) {
       // We need to strip metadata from stack frames before sending them to Sentry since these are client side only.
-      // TODO(lforst): Move this cleanup logic into a more central place in the SDK.
       client.on('beforeEnvelope', envelope => {
         forEachEnvelopeItem(envelope, (item, type) => {
           if (type === 'event') {

packages/core/src/integrations/third-party-errors-filter.ts

@@ -53,46 +53,28 @@ export function getMetadataForUrl(parser: StackParser, filename: string): any |
  * Metadata is injected by the Sentry bundler plugins using the `_experiments.moduleMetadata` config option.
  */
 export function addMetadataToStackFrames(parser: StackParser, event: Event): void {
-  try {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    event.exception!.values!.forEach(exception => {
-      if (!exception.stacktrace) {
+  event.exception?.values?.forEach(exception => {
+    exception.stacktrace?.frames?.forEach(frame => {
+      if (!frame.filename || frame.module_metadata) {
         return;
       }
 
-      for (const frame of exception.stacktrace.frames || []) {
-        if (!frame.filename || frame.module_metadata) {
-          continue;
-        }
+      const metadata = getMetadataForUrl(parser, frame.filename);
 
-        const metadata = getMetadataForUrl(parser, frame.filename);
-
-        if (metadata) {
-          frame.module_metadata = metadata;
-        }
+      if (metadata) {
+        frame.module_metadata = metadata;
       }
     });
-  } catch {
-    // To save bundle size we're just try catching here instead of checking for the existence of all the different objects.
-  }
+  });
 }
 
 /**
  * Strips metadata from stack frames.
  */
 export function stripMetadataFromStackFrames(event: Event): void {
-  try {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    event.exception!.values!.forEach(exception => {
-      if (!exception.stacktrace) {
-        return;
-      }
-
-      for (const frame of exception.stacktrace.frames || []) {
-        delete frame.module_metadata;
-      }
+  event.exception?.values?.forEach(exception => {
+    exception.stacktrace?.frames?.forEach(frame => {
+      delete frame.module_metadata;
     });
-  } catch {
-    // To save bundle size we're just try catching here instead of checking for the existence of all the different objects.
-  }
+  });
 }