ci: Fix size limit action base upload (#11124)

mydea · web-flow · commit 7e2c5f178f5e · 2024-03-15T11:14:37.000Z
Noticed this is failing e.g. https://github.com/getsentry/sentry-javascript/actions/runs/8294578489/job/22700116991, it was an incorrect check: if there is no comparison branch, we don't need a PR.
diff --git a/dev-packages/size-limit-gh-action/index.mjs b/dev-packages/size-limit-gh-action/index.mjs
@@ -187,7 +187,7 @@ async function run() {
     const githubToken = getInput('github_token');
     const threshold = getInput('threshold');
 
-    if (!comparisonBranch && !pr) {
+    if (comparisonBranch && !pr) {
       throw new Error('No PR found. Only pull_request workflows are supported.');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ async function run() {`
`187`	`187`	`const githubToken = getInput('github_token');`
`188`	`188`	`const threshold = getInput('threshold');`
`189`	`189`
`190`		`- if (!comparisonBranch && !pr) {`
	`190`	`+ if (comparisonBranch && !pr) {`
`191`	`191`	`throw new Error('No PR found. Only pull_request workflows are supported.');`
`192`	`192`	`}`
`193`	`193`