ref: Make handleException private

Author: mydea

packages/replay/src/replay.ts

@@ -175,7 +175,7 @@ export class ReplayContainer implements ReplayContainerInterface {
 
     // If there is no session, then something bad has happened - can't continue
     if (!this.session) {
-      this.handleException(new Error('No session found'));
+      this._handleException(new Error('No session found'));
       return;
     }
 
@@ -222,7 +222,7 @@ export class ReplayContainer implements ReplayContainerInterface {
         emit: this._handleRecordingEmit,
       });
     } catch (err) {
-      this.handleException(err);
+      this._handleException(err);
     }
   }
 
@@ -252,7 +252,7 @@ export class ReplayContainer implements ReplayContainerInterface {
       this.eventBuffer?.destroy();
       this.eventBuffer = null;
     } catch (err) {
-      this.handleException(err);
+      this._handleException(err);
     }
   }
 
@@ -269,7 +269,7 @@ export class ReplayContainer implements ReplayContainerInterface {
         this._stopRecording = undefined;
       }
     } catch (err) {
-      this.handleException(err);
+      this._handleException(err);
     }
   }
 
@@ -284,15 +284,6 @@ export class ReplayContainer implements ReplayContainerInterface {
     this.startRecording();
   }
 
-  /** A wrapper to conditionally capture exceptions. */
-  public handleException(error: unknown): void {
-    __DEBUG_BUILD__ && logger.error('[Replay]', error);
-
-    if (__DEBUG_BUILD__ && this._options._experiments && this._options._experiments.captureExceptions) {
-      captureException(error);
-    }
-  }
-
   /**
    * We want to batch uploads of replay events. Save events only if
    * `<flushMinDelay>` milliseconds have elapsed since the last event
@@ -360,6 +351,15 @@ export class ReplayContainer implements ReplayContainerInterface {
     return this._debouncedFlush.flush() as Promise<void>;
   }
 
+  /** A wrapper to conditionally capture exceptions. */
+  private _handleException(error: unknown): void {
+    __DEBUG_BUILD__ && logger.error('[Replay]', error);
+
+    if (__DEBUG_BUILD__ && this._options._experiments && this._options._experiments.captureExceptions) {
+      captureException(error);
+    }
+  }
+
   /**
    * Loads a session from storage, or creates a new one if it does not exist or
    * is expired.
@@ -434,7 +434,7 @@ export class ReplayContainer implements ReplayContainerInterface {
         this._hasInitializedCoreListeners = true;
       }
     } catch (err) {
-      this.handleException(err);
+      this._handleException(err);
     }
 
     // _performanceObserver //
@@ -462,7 +462,7 @@ export class ReplayContainer implements ReplayContainerInterface {
         this._performanceObserver = null;
       }
     } catch (err) {
-      this.handleException(err);
+      this._handleException(err);
     }
   }
 
@@ -838,7 +838,7 @@ export class ReplayContainer implements ReplayContainerInterface {
         eventContext,
       });
     } catch (err) {
-      this.handleException(err);
+      this._handleException(err);
     }
   }
 
@@ -1031,7 +1031,7 @@ export class ReplayContainer implements ReplayContainerInterface {
       setContext('Replays', {
         _retryCount: this._retryCount,
       });
-      this.handleException(err);
+      this._handleException(err);
 
       // If an error happened here, it's likely that uploading the attachment
       // failed, we'll can retry with the same events payload

packages/replay/test/integration/sendReplayEvent.test.ts

@@ -389,8 +389,8 @@ describe('Integration | sendReplayEvent', () => {
     // Suppress console.errors
     const mockConsole = jest.spyOn(console, 'error').mockImplementation(jest.fn());
 
-    // Check errors
-    const spyHandleException = jest.spyOn(replay, 'handleException');
+    // @ts-ignore privaye api - Check errors
+    const spyHandleException = jest.spyOn(replay, '_handleException');
 
     expect(replay.session?.segmentId).toBe(0);