feat(eslint): Make class member accessibility explicit

Add @typescript-eslint/explicit-member-accessibility rule to make
sure class members declarations have explicit accessibility (public,
private, protected).

Author: AbhiPrasad

packages/eslint-config-sdk/src/index.js

@@ -104,6 +104,9 @@ module.exports = {
         // instead of any. This is especially important for methods that expose a public API, as users
         // should know exactly what they have to provide to use those methods. Turned off in tests.
         '@typescript-eslint/no-unsafe-member-access': 'error',
+
+        // Be explicit about class member accessibility (public, private, protected)
+        '@typescript-eslint/explicit-member-accessibility': ['error'],
       },
     },
     {

packages/hub/src/session.ts

@@ -18,15 +18,15 @@ export class Session implements SessionInterface {
   public ipAddress?: string;
   public init: boolean = true;
 
-  constructor(context?: Omit<SessionContext, 'started' | 'status'>) {
+  public constructor(context?: Omit<SessionContext, 'started' | 'status'>) {
     if (context) {
       this.update(context);
     }
   }
 
   /** JSDoc */
   // eslint-disable-next-line complexity
-  update(context: SessionContext = {}): void {
+  public update(context: SessionContext = {}): void {
     if (context.user) {
       if (context.user.ip_address) {
         this.ipAddress = context.user.ip_address;
@@ -78,7 +78,7 @@ export class Session implements SessionInterface {
   }
 
   /** JSDoc */
-  close(status?: Exclude<SessionStatus, SessionStatus.Ok>): void {
+  public close(status?: Exclude<SessionStatus, SessionStatus.Ok>): void {
     if (status) {
       this.update({ status });
     } else if (this.status === SessionStatus.Ok) {
@@ -89,7 +89,7 @@ export class Session implements SessionInterface {
   }
 
   /** JSDoc */
-  toJSON(): {
+  public toJSON(): {
     init: boolean;
     sid: string;
     did?: string;