ref: Avoid optional chaining

Author: mydea

packages/react/src/reactrouterv6.tsx

@@ -226,7 +226,7 @@ export function wrapUseRoutes(origUseRoutes: UseRoutes): UseRoutes {
 
       // A value with stable identity to either pick `locationArg` if available or `location` if not
       const stableLocationParam =
-        typeof locationArg === 'string' || locationArg?.pathname !== undefined
+        typeof locationArg === 'string' || locationArg && locationArg.pathname !== undefined
           ? (locationArg as { pathname: string })
           : location;
 

packages/tracing/.eslintrc.js

@@ -1,3 +1,11 @@
 module.exports = {
   extends: ['../../.eslintrc.js'],
+  overrides: [
+    {
+      files: ['src/integrations/node/**'],
+      rules: {
+        '@sentry-internal/sdk/no-optional-chaining': 'off',
+      },
+    },
+  ],
 };

packages/tracing/src/browser/browsertracing.ts

@@ -90,7 +90,7 @@ export interface BrowserTracingOptions extends RequestInstrumentationOptions {
    *
    * Default: undefined
    */
-  _experiments?: Partial<{ enableLongTask: boolean; enableInteractions: boolean }>;
+  _experiments: Partial<{ enableLongTask: boolean; enableInteractions: boolean }>;
 
   /**
    * beforeNavigate is called before a pageload/navigation transaction is created and allows users to modify transaction
@@ -170,7 +170,7 @@ export class BrowserTracing implements Integration {
     }
 
     startTrackingWebVitals();
-    if (this.options._experiments?.enableLongTask) {
+    if (this.options._experiments.enableLongTask) {
       startTrackingLongTasks();
     }
   }
@@ -203,7 +203,7 @@ export class BrowserTracing implements Integration {
       registerBackgroundTabDetection();
     }
 
-    if (_experiments?.enableInteractions) {
+    if (_experiments.enableInteractions) {
       this._registerInteractionListener();
     }
 
@@ -258,7 +258,7 @@ export class BrowserTracing implements Integration {
         : finalContext.metadata;
 
     this._latestRouteName = finalContext.name;
-    this._latestRouteSource = finalContext.metadata?.source;
+    this._latestRouteSource = finalContext.metadata && finalContext.metadata.source;
 
     if (finalContext.sampled === false) {
       __DEBUG_BUILD__ &&

packages/utils/src/requestdata.ts

@@ -295,13 +295,13 @@ export function addRequestDataToEvent(
 ): Event {
   const include = {
     ...DEFAULT_INCLUDES,
-    ...options?.include,
+    ...(options ? options.include : undefined),
   };
 
   if (include.request) {
     const extractedRequestData = Array.isArray(include.request)
-      ? extractRequestData(req, { include: include.request, deps: options?.deps })
-      : extractRequestData(req, { deps: options?.deps });
+      ? extractRequestData(req, { include: include.request, deps: options ? options.deps : undefined })
+      : extractRequestData(req, { deps: options ? options.deps : undefined });
 
     event.request = {
       ...event.request,

packages/utils/src/stacktrace.ts

@@ -168,7 +168,7 @@ function node(getModule?: GetModuleFn): StackLineParserFn {
       functionName = typeName ? `${typeName}.${methodName}` : methodName;
     }
 
-    const filename = lineMatch[2]?.startsWith('file://') ? lineMatch[2].slice(7) : lineMatch[2];
+    const filename = lineMatch[2] && lineMatch[2].startsWith('file://') ? lineMatch[2].slice(7) : lineMatch[2];
     const isNative = lineMatch[5] === 'native';
     const isInternal =
       isNative || (filename && !filename.startsWith('/') && !filename.startsWith('.') && filename.indexOf(':\\') !== 1);
@@ -180,7 +180,7 @@ function node(getModule?: GetModuleFn): StackLineParserFn {
 
     return {
       filename,
-      module: getModule?.(filename),
+      module: getModule ? getModule(filename) : undefined,
       function: functionName,
       lineno: parseInt(lineMatch[3], 10) || undefined,
       colno: parseInt(lineMatch[4], 10) || undefined,

packages/vue/src/components.ts

@@ -43,7 +43,7 @@ export const formatComponentName = (vm?: ViewModel, includeFile?: boolean): stri
 };
 
 export const generateComponentTrace = (vm?: ViewModel): string => {
-  if ((vm?._isVue || vm?.__isVue) && vm?.$parent) {
+  if (vm && (vm._isVue || vm.__isVue) && vm.$parent) {
     const tree = [];
     let currentRecursiveSequence = 0;
     while (vm) {

packages/vue/src/tracing.ts

@@ -30,7 +30,8 @@ const HOOKS: { [key in Operation]: Hook[] } = {
 
 /** Grabs active transaction off scope, if any */
 export function getActiveTransaction(): Transaction | undefined {
-  return getCurrentHub().getScope()?.getTransaction();
+  const scope = getCurrentHub().getScope();
+  return scope && scope.getTransaction();
 }
 
 /** Finish top-level span and activity with a debounce configured using `timeout` option */
@@ -40,7 +41,7 @@ function finishRootSpan(vm: VueSentry, timestamp: number, timeout: number): void
   }
 
   vm.$_sentryRootSpanTimer = setTimeout(() => {
-    if (vm.$root?.$_sentryRootSpan) {
+    if (vm.$root.$_sentryRootSpan) {
       vm.$root.$_sentryRootSpan.finish(timestamp);
       vm.$root.$_sentryRootSpan = undefined;
     }
@@ -96,7 +97,7 @@ export const createTracingMixins = (options: TracingOptions): Mixins => {
         // Start a new span if current hook is a 'before' hook.
         // Otherwise, retrieve the current span and finish it.
         if (internalHook == internalHooks[0]) {
-          const activeTransaction = this.$root?.$_sentryRootSpan || getActiveTransaction();
+          const activeTransaction = this.$root.$_sentryRootSpan || getActiveTransaction();
           if (activeTransaction) {
             // Cancel old span for this hook operation in case it didn't get cleaned up. We're not actually sure if it
             // will ever be the case that cleanup hooks re not called, but we had users report that spans didn't get