Skip to content

Commit 72ddbde

Browse files
Lms24Luca Forstner
andauthored
feat(core): Deprecate finish on Span interface in favour of end (#10161)
Looks like we forgot to deprecate the method on the interface (it's already deprecated on the class). --------- Co-authored-by: Luca Forstner <[email protected]>
1 parent b60a3c2 commit 72ddbde

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

packages/types/src/span.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,10 @@ export interface Span extends SpanContext {
235235

236236
/**
237237
* Sets the finish timestamp on the current span.
238+
*
238239
* @param endTimestamp Takes an endTimestamp if the end should not be the time when you call this function.
240+
*
241+
* @deprecated Use `.end()` instead.
239242
*/
240243
finish(endTimestamp?: number): void;
241244

0 commit comments

Comments
 (0)