ci: Move replay metrics into dedicated package

Author: mydea

.github/workflows/build.yml

@@ -793,8 +793,8 @@ jobs:
         run: |
           echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1
 
-  replay_metrics:
-    name: Replay Metrics
+  overhead_metrics:
+    name: Overhead metrics
     needs: [job_get_metadata, job_build]
     runs-on: ubuntu-20.04
     timeout-minutes: 30
@@ -819,18 +819,14 @@ jobs:
           path: ${{ env.CACHED_BUILD_PATHS }}
           key: ${{ env.BUILD_CACHE_KEY }}
 
-      - name: Setup
-        run: yarn install
-        working-directory: packages/replay/metrics
-
       - name: Collect
         run: yarn ci:collect
-        working-directory: packages/replay/metrics
+        working-directory: packages/metrics
 
       - name: Process
         id: process
         run: yarn ci:process
-        working-directory: packages/replay/metrics
+        working-directory: packages/metrics
         # Don't run on forks - the PR comment cannot be added.
         if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
         env:

package.json

@@ -44,6 +44,7 @@
     "packages/hub",
     "packages/integration-tests",
     "packages/integrations",
+    "packages/metrics",
     "packages/nextjs",
     "packages/node",
     "packages/node-integration-tests",

packages/replay/metrics/.eslintrc.cjs renamed to packages/metrics/.eslintrc.cjs

@@ -1,5 +1,5 @@
 module.exports = {
-  extends: ['../.eslintrc.js'],
+  extends: ['../../.eslintrc.js'],
   ignorePatterns: ['test-apps'],
   overrides: [
     {
@@ -8,6 +8,9 @@ module.exports = {
         'no-console': 'off',
         '@typescript-eslint/no-non-null-assertion': 'off',
         'import/no-unresolved': 'off',
+        '@sentry-internal/sdk/no-optional-chaining': 'off',
+        '@sentry-internal/sdk/no-nullish-coalescing': 'off',
+        'jsdoc/require-jsdoc': 'off',
       },
     },
   ],

packages/replay/metrics/.gitignore renamed to packages/metrics/.gitignore

@@ -1,5 +1,7 @@
-import { Metrics, MetricsCollector } from '../../src/collector.js';
-import { MetricsStats, NumberProvider } from '../../src/results/metrics-stats.js';
+import type { Metrics} from '../../src/collector.js';
+import { MetricsCollector } from '../../src/collector.js';
+import type { NumberProvider } from '../../src/results/metrics-stats.js';
+import { MetricsStats } from '../../src/results/metrics-stats.js';
 import { JankTestScenario } from '../../src/scenarios.js';
 import { printStats } from '../../src/util/console.js';
 import { latestResultFile } from './env.js';

packages/replay/metrics/README.md renamed to packages/metrics/README.md

@@ -1,4 +1,5 @@
-import { Metrics, MetricsCollector } from '../../src/collector.js';
+import type { Metrics} from '../../src/collector.js';
+import { MetricsCollector } from '../../src/collector.js';
 import { MetricsStats } from '../../src/results/metrics-stats.js';
 import { JankTestScenario } from '../../src/scenarios.js';
 import { printStats } from '../../src/util/console.js';