Skip to content

Commit 6a906a2

Browse files
committed
possibly fix test on CI??!
1 parent 18d5a48 commit 6a906a2

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/route-handlers.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@ import { waitForError, waitForTransaction } from '@sentry-internal/event-proxy-s
44
test.only('Should create a transaction for route handlers', async ({ request }) => {
55
const routehandlerTransactionPromise = waitForTransaction('nextjs-13-app-dir', async transactionEvent => {
66
console.log('transactionEvent', JSON.stringify(transactionEvent, null, 2));
7-
return transactionEvent?.transaction === 'GET /route-handlers/[param]';
7+
return (
8+
transactionEvent.transaction === 'GET /route-handlers/[param]' &&
9+
transactionEvent.contexts?.trace?.data?.WIP_TEST === 'yes'
10+
);
811
});
912

1013
const response = await request.get('/route-handlers/foo', { headers: { 'x-yeet': 'test-value' } });

packages/nextjs/src/common/wrapRouteHandlerWithSentry.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ function startOrUpdateSpan(spanName: string, cb: (rootSpan: Span) => Promise<Res
3434
rootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
3535
rootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_OP, 'http.server');
3636
rootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.function.nextjs');
37+
rootSpan.setAttribute('WIP_TEST', 'yes');
3738

3839
return cb(rootSpan);
3940
} else {
@@ -46,6 +47,7 @@ function startOrUpdateSpan(spanName: string, cb: (rootSpan: Span) => Promise<Res
4647
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
4748
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.nextjs',
4849
'TEST-ATTRIBUTE-HERE??!': 'yes',
50+
WIP_TEST: 'yes',
4951
},
5052
},
5153
(span: Span) => {
@@ -76,6 +78,8 @@ export function wrapRouteHandlerWithSentry<F extends (...args: any[]) => any>(
7678
},
7779
});
7880

81+
console.log('DO IT NOW???');
82+
7983
try {
8084
return await startOrUpdateSpan(`${method} ${parameterizedRoute}`, async (rootSpan: Span) => {
8185
// Ensure root span has the correct isolation scope - even if it was triggered by next

0 commit comments

Comments
 (0)