fix: Remove circular dependency between span and transaction

Author: AbhiPrasad

packages/tracing/src/idletransaction.ts

@@ -3,9 +3,9 @@ import { Hub } from '@sentry/hub';
 import { TransactionContext } from '@sentry/types';
 import { logger, timestampWithMs } from '@sentry/utils';
 
-import { Span } from './span';
+import { Span, SpanRecorder } from './span';
 import { SpanStatus } from './spanstatus';
-import { SpanRecorder, Transaction } from './transaction';
+import { Transaction } from './transaction';
 
 export const DEFAULT_IDLE_TIMEOUT = 1000;
 

packages/tracing/src/span.ts

@@ -1,8 +1,8 @@
+// tslint:disable:max-classes-per-file
 import { Span as SpanInterface, SpanContext } from '@sentry/types';
 import { dropUndefinedKeys, timestampWithMs, uuid4 } from '@sentry/utils';
 
 import { SpanStatus } from './spanstatus';
-import { SpanRecorder } from './transaction';
 
 export const TRACEPARENT_REGEXP = new RegExp(
   '^[ \\t]*' + // whitespace
@@ -12,6 +12,35 @@ export const TRACEPARENT_REGEXP = new RegExp(
     '[ \\t]*$', // whitespace
 );
 
+/**
+ * Keeps track of finished spans for a given transaction
+ * @internal
+ * @hideconstructor
+ * @hidden
+ */
+export class SpanRecorder {
+  private readonly _maxlen: number;
+  public spans: Span[] = [];
+
+  public constructor(maxlen: number = 1000) {
+    this._maxlen = maxlen;
+  }
+
+  /**
+   * This is just so that we don't run out of memory while recording a lot
+   * of spans. At some point we just stop and flush out the start of the
+   * trace tree (i.e.the first n spans with the smallest
+   * start_timestamp).
+   */
+  public add(span: Span): void {
+    if (this.spans.length > this._maxlen) {
+      span.spanRecorder = undefined;
+    } else {
+      this.spans.push(span);
+    }
+  }
+}
+
 /**
  * Span contains all data about a span
  */

packages/tracing/src/transaction.ts

@@ -1,38 +1,8 @@
-// tslint:disable:max-classes-per-file
 import { getCurrentHub, Hub } from '@sentry/hub';
 import { TransactionContext } from '@sentry/types';
 import { isInstanceOf, logger } from '@sentry/utils';
 
-import { Span as SpanClass } from './span';
-
-/**
- * Keeps track of finished spans for a given transaction
- * @internal
- * @hideconstructor
- * @hidden
- */
-export class SpanRecorder {
-  private readonly _maxlen: number;
-  public spans: SpanClass[] = [];
-
-  public constructor(maxlen: number = 1000) {
-    this._maxlen = maxlen;
-  }
-
-  /**
-   * This is just so that we don't run out of memory while recording a lot
-   * of spans. At some point we just stop and flush out the start of the
-   * trace tree (i.e.the first n spans with the smallest
-   * start_timestamp).
-   */
-  public add(span: SpanClass): void {
-    if (this.spans.length > this._maxlen) {
-      span.spanRecorder = undefined;
-    } else {
-      this.spans.push(span);
-    }
-  }
-}
+import { Span as SpanClass, SpanRecorder } from './span';
 
 /** JSDoc */
 export class Transaction extends SpanClass {