PR feedback

Author: mydea

packages/node-experimental/src/sdk/spanProcessor.ts

@@ -12,7 +12,7 @@ import type { NodeExperimentalClient } from '../types';
  */
 export class NodeExperimentalSentrySpanProcessor extends SentrySpanProcessor {
   /** @inheritDoc */
-  protected _shouldCaptureSentrySpan(span: Span): boolean {
+  protected _shouldSendSpanToSentry(span: Span): boolean {
     const client = getCurrentHub().getClient<NodeExperimentalClient>();
     const httpIntegration = client ? client.getIntegration(Http) : undefined;
     const fetchIntegration = client ? client.getIntegration(NodeFetch) : undefined;

packages/opentelemetry/package.json

@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "main": "build/cjs/index.js",
   "module": "build/esm/index.js",

packages/opentelemetry/src/spanProcessor.ts

@@ -66,7 +66,7 @@ export class SentrySpanProcessor extends BatchSpanProcessor implements SpanProce
   public onEnd(span: Span): void {
     __DEBUG_BUILD__ && logger.log(`[Tracing] Finishing span "${span.name}" (${span.spanContext().spanId})`);
 
-    if (!this._shouldCaptureSentrySpan(span)) {
+    if (!this._shouldSendSpanToSentry(span)) {
       // Prevent this being called to super.onEnd(), which would pass this to the span exporter
       return;
     }
@@ -80,7 +80,7 @@ export class SentrySpanProcessor extends BatchSpanProcessor implements SpanProce
    * You can overwrite this in a sub class to implement custom behavior for dropping spans.
    * If you return `false` here, the span will not be passed to the exporter and thus not be sent.
    */
-  protected _shouldCaptureSentrySpan(_span: Span): boolean {
+  protected _shouldSendSpanToSentry(_span: Span): boolean {
     return true;
   }
 }