🗜

Author: timfish

packages/node/src/transports/http-module.ts

@@ -1,5 +1,6 @@
 import { IncomingHttpHeaders, RequestOptions as HTTPRequestOptions } from 'http';
 import { RequestOptions as HTTPSRequestOptions } from 'https';
+import { Writable } from 'stream';
 import { URL } from 'url';
 
 export type HTTPModuleRequestOptions = HTTPRequestOptions | HTTPSRequestOptions | string | URL;
@@ -15,15 +16,6 @@ export interface HTTPModuleRequestIncomingMessage {
   setEncoding(encoding: string): void;
 }
 
-/**
- * Cut version of http.ClientRequest.
- * Some transports work in a special Javascript environment where http.IncomingMessage is not available.
- */
-export interface HTTPModuleClientRequest {
-  end(chunk: string | Uint8Array): void;
-  on(event: 'error', listener: () => void): void;
-}
-
 /**
  * Internal used interface for typescript.
  * @hidden
@@ -34,10 +26,7 @@ export interface HTTPModule {
    * @param options These are {@see TransportOptions}
    * @param callback Callback when request is finished
    */
-  request(
-    options: HTTPModuleRequestOptions,
-    callback?: (res: HTTPModuleRequestIncomingMessage) => void,
-  ): HTTPModuleClientRequest;
+  request(options: HTTPModuleRequestOptions, callback?: (res: HTTPModuleRequestIncomingMessage) => void): Writable;
 
   // This is the type for nodejs versions that handle the URL argument
   // (v10.9.0+), but we do not use it just yet because we support older node

packages/node/src/transports/http.ts

@@ -8,7 +8,9 @@ import {
 } from '@sentry/types';
 import * as http from 'http';
 import * as https from 'https';
+import { Readable } from 'stream';
 import { URL } from 'url';
+import { createGzip } from 'zlib';
 
 import { HTTPModule } from './http-module';
 
@@ -23,6 +25,22 @@ export interface NodeTransportOptions extends BaseTransportOptions {
   httpModule?: HTTPModule;
 }
 
+// Estimated maximum size for reasonable standalone event
+const GZIP_THRESHOLD = 1024 * 32;
+
+/**
+ * Gets a stream from a Uint8Array or string
+ * Readable.from is ideal but was added in node.js v12.3.0 and v10.17.0
+ */
+function streamFromBody(body: Uint8Array | string): Readable {
+  return new Readable({
+    read() {
+      this.push(body);
+      this.push(null);
+    },
+  });
+}
+
 /**
  * Creates a Transport that uses native the native 'http' and 'https' modules to send events to Sentry.
  */
@@ -85,6 +103,17 @@ function createRequestExecutor(
   const { hostname, pathname, port, protocol, search } = new URL(options.url);
   return function makeRequest(request: TransportRequest): Promise<TransportMakeRequestResponse> {
     return new Promise((resolve, reject) => {
+      let body = streamFromBody(request.body);
+
+      if (request.body.length > GZIP_THRESHOLD) {
+        options.headers = {
+          ...options.headers,
+          'content-encoding': 'gzip',
+        };
+
+        body = body.pipe(createGzip());
+      }
+
       const req = httpModule.request(
         {
           method: 'POST',
@@ -123,7 +152,7 @@ function createRequestExecutor(
       );
 
       req.on('error', reject);
-      req.end(request.body);
+      body.pipe(req);
     });
   };
 }