Update rules

Author: AbhiPrasad

.eslintrc.js

@@ -6,23 +6,28 @@ module.exports = {
   extends: ['prettier', 'eslint:recommended'],
   plugins: ['sentry-sdk'],
   overrides: [
+    {
+      files: ['*.js'],
+      rules: {
+        'no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+      },
+    },
     {
       files: ['*.ts'],
       extends: ['plugin:@typescript-eslint/recommended', 'prettier/@typescript-eslint'],
       plugins: ['@typescript-eslint'],
       parser: '@typescript-eslint/parser',
       rules: {
         'sentry-sdk/no-async-await': 'error',
+        // Make sure variables marked with _ are ignored (ex. _varName)
+        '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
       },
     },
     {
       env: {
         jest: true,
       },
       files: ['*.test.ts'],
-      extends: ['plugin:@typescript-eslint/recommended', 'prettier/@typescript-eslint'],
-      plugins: ['@typescript-eslint'],
-      parser: '@typescript-eslint/parser',
     },
     {
       files: ['*.config.js'],

packages/browser/.eslintrc.js

@@ -5,7 +5,7 @@ module.exports = {
     browser: true,
   },
   extends: ['../../.eslintrc.js'],
-  ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
+  ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*', 'src/loader.js'],
   overrides: [
     {
       files: ['test/integration/**/*'],
@@ -23,5 +23,7 @@ module.exports = {
       },
     },
   ],
-  rules: {},
+  rules: {
+    'no-prototype-builtins': 'off',
+  },
 };

packages/browser/src/backend.ts

@@ -62,7 +62,7 @@ export class BrowserBackend extends BaseBackend<BrowserOptions> {
   /**
    * @inheritDoc
    */
-  public eventFromException(exception: any, hint?: EventHint): PromiseLike<Event> {
+  public eventFromException(exception: unknown, hint?: EventHint): PromiseLike<Event> {
     return eventFromException(this._options, exception, hint);
   }
   /**

packages/browser/src/eventbuilder.ts

@@ -18,7 +18,7 @@ import { computeStackTrace } from './tracekit';
  * Builds and Event from a Exception
  * @hidden
  */
-export function eventFromException(options: Options, exception: any, hint?: EventHint): PromiseLike<Event> {
+export function eventFromException(options: Options, exception: unknown, hint?: EventHint): PromiseLike<Event> {
   const syntheticException = (hint && hint.syntheticException) || undefined;
   const event = eventFromUnknownInput(exception, syntheticException, {
     attachStacktrace: options.attachStacktrace,
@@ -71,7 +71,7 @@ export function eventFromUnknownInput(
   if (isErrorEvent(exception as ErrorEvent) && (exception as ErrorEvent).error) {
     // If it is an ErrorEvent with `error` property, extract it to get actual Error
     const errorEvent = exception as ErrorEvent;
-    exception = errorEvent.error; // tslint:disable-line:no-parameter-reassignment
+    exception = errorEvent.error;
     event = eventFromStacktrace(computeStackTrace(exception as Error));
     return event;
   }
@@ -97,7 +97,7 @@ export function eventFromUnknownInput(
     // If it is plain Object or Event, serialize it manually and extract options
     // This will allow us to group events based on top-level keys
     // which is much better than creating new group when any key/value change
-    const objectException = exception as {};
+    const objectException = exception as Record<string, unknown>;
     event = eventFromPlainObject(objectException, syntheticException, options.rejection);
     addExceptionMechanism(event, {
       synthetic: true,

packages/browser/src/helpers.ts

@@ -2,7 +2,7 @@ import { API, captureException, withScope } from '@sentry/core';
 import { DsnLike, Event as SentryEvent, Mechanism, Scope, WrappedFunction } from '@sentry/types';
 import { addExceptionMechanism, addExceptionTypeValue, logger } from '@sentry/utils';
 
-let ignoreOnError: number = 0;
+let ignoreOnError = 0;
 
 /**
  * @hidden
@@ -36,6 +36,7 @@ export function wrap(
     mechanism?: Mechanism;
   } = {},
   before?: WrappedFunction,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
 ): any {
   // tslint:disable-next-line:strict-type-predicates
   if (typeof fn !== 'function') {
@@ -59,6 +60,8 @@ export function wrap(
     return fn;
   }
 
+  /* eslint-disable prefer-rest-params */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const sentryWrapped: WrappedFunction = function(this: any): void {
     const args = Array.prototype.slice.call(arguments);
 
@@ -69,6 +72,7 @@ export function wrap(
         before.apply(this, arguments);
       }
 
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const wrappedArguments = args.map((arg: any) => wrap(arg, options));
 
       if (fn.handleEvent) {
@@ -110,6 +114,7 @@ export function wrap(
       throw ex;
     }
   };
+  /* eslint-enable prefer-rest-params */
 
   // Accessing some objects may throw
   // ref: https://github.com/getsentry/sentry-javascript/issues/1168
@@ -119,7 +124,7 @@ export function wrap(
         sentryWrapped[property] = fn[property];
       }
     }
-  } catch (_oO) {} // tslint:disable-line:no-empty
+  } catch (_oO) {} // eslint-disable-line no-empty
 
   fn.prototype = fn.prototype || {};
   sentryWrapped.prototype = fn.prototype;
@@ -163,6 +168,7 @@ export function wrap(
  * All properties the report dialog supports
  */
 export interface ReportDialogOptions {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   [key: string]: any;
   eventId?: string;
   dsn?: DsnLike;

packages/browser/src/integrations/breadcrumbs.ts

@@ -13,6 +13,7 @@ import {
  * @hidden
  */
 export interface SentryWrappedXMLHttpRequest extends XMLHttpRequest {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   [key: string]: any;
   __sentry_xhr__?: {
     method?: string;
@@ -44,7 +45,7 @@ export class Breadcrumbs implements Integration {
   /**
    * @inheritDoc
    */
-  public static id: string = 'Breadcrumbs';
+  public static id = 'Breadcrumbs';
 
   /** JSDoc */
   private readonly _options: BreadcrumbsOptions;
@@ -87,6 +88,7 @@ export class Breadcrumbs implements Integration {
   /**
    * Creates breadcrumbs from console API calls
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _consoleBreadcrumb(handlerData: { [key: string]: any }): void {
     const breadcrumb = {
       category: 'console',
@@ -117,6 +119,7 @@ export class Breadcrumbs implements Integration {
   /**
    * Creates breadcrumbs from DOM API calls
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _domBreadcrumb(handlerData: { [key: string]: any }): void {
     let target;
 
@@ -148,6 +151,7 @@ export class Breadcrumbs implements Integration {
   /**
    * Creates breadcrumbs from XHR API calls
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _xhrBreadcrumb(handlerData: { [key: string]: any }): void {
     if (handlerData.endTimestamp) {
       // We only capture complete, non-sentry requests
@@ -173,6 +177,7 @@ export class Breadcrumbs implements Integration {
   /**
    * Creates breadcrumbs from fetch API calls
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _fetchBreadcrumb(handlerData: { [key: string]: any }): void {
     // We only capture complete fetch requests
     if (!handlerData.endTimestamp) {
@@ -218,6 +223,7 @@ export class Breadcrumbs implements Integration {
   /**
    * Creates breadcrumbs from history API calls
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _historyBreadcrumb(handlerData: { [key: string]: any }): void {
     const global = getGlobalObject<Window>();
     let from = handlerData.from;

packages/browser/src/integrations/globalhandlers.ts

@@ -29,16 +29,16 @@ export class GlobalHandlers implements Integration {
   /**
    * @inheritDoc
    */
-  public static id: string = 'GlobalHandlers';
+  public static id = 'GlobalHandlers';
 
   /** JSDoc */
   private readonly _options: GlobalHandlersIntegrations;
 
   /** JSDoc */
-  private _onErrorHandlerInstalled: boolean = false;
+  private _onErrorHandlerInstalled = false;
 
   /** JSDoc */
-  private _onUnhandledRejectionHandlerInstalled: boolean = false;
+  private _onUnhandledRejectionHandlerInstalled = false;
 
   /** JSDoc */
   public constructor(options?: GlobalHandlersIntegrations) {
@@ -72,6 +72,7 @@ export class GlobalHandlers implements Integration {
     }
 
     addInstrumentationHandler({
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       callback: (data: { msg: any; url: any; line: any; column: any; error: any }) => {
         const error = data.error;
         const currentHub = getCurrentHub();
@@ -117,6 +118,7 @@ export class GlobalHandlers implements Integration {
     }
 
     addInstrumentationHandler({
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       callback: (e: any) => {
         let error = e;
 
@@ -177,6 +179,7 @@ export class GlobalHandlers implements Integration {
   /**
    * This function creates a stack from an old, error-less onerror handler.
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _eventFromIncompleteOnError(msg: any, url: any, line: any, column: any): Event {
     const ERROR_TYPES_RE = /^(?:[Uu]ncaught (?:exception: )?)?(?:((?:Eval|Internal|Range|Reference|Syntax|Type|URI|)Error): )?(.*)$/i;
 
@@ -209,6 +212,7 @@ export class GlobalHandlers implements Integration {
   /**
    * This function creates an Event from an TraceKitStackTrace that has part of it missing.
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _eventFromIncompleteRejection(error: any): Event {
     return {
       exception: {
@@ -223,6 +227,7 @@ export class GlobalHandlers implements Integration {
   }
 
   /** JSDoc */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _enhanceEventWithInitialFrame(event: Event, url: any, line: any, column: any): Event {
     event.exception = event.exception || {};
     event.exception.values = event.exception.values || [];

packages/browser/src/integrations/linkederrors.ts

@@ -18,7 +18,7 @@ export class LinkedErrors implements Integration {
   /**
    * @inheritDoc
    */
-  public static id: string = 'LinkedErrors';
+  public static id = 'LinkedErrors';
 
   /**
    * @inheritDoc

packages/browser/src/integrations/trycatch.ts

@@ -56,7 +56,7 @@ export class TryCatch implements Integration {
   /**
    * @inheritDoc
    */
-  public static id: string = 'TryCatch';
+  public static id = 'TryCatch';
 
   /** JSDoc */
   private readonly _options: TryCatchOptions;
@@ -77,6 +77,7 @@ export class TryCatch implements Integration {
 
   /** JSDoc */
   private _wrapTimeFunction(original: () => void): () => number {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     return function(this: any, ...args: any[]): number {
       const originalCallback = args[0];
       args[0] = wrap(originalCallback, {
@@ -91,7 +92,9 @@ export class TryCatch implements Integration {
   }
 
   /** JSDoc */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private _wrapRAF(original: any): (callback: () => void) => any {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     return function(this: any, callback: () => void): () => void {
       return original.call(
         this,
@@ -111,6 +114,7 @@ export class TryCatch implements Integration {
 
   /** JSDoc */
   private _wrapEventTarget(target: string): void {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const global = getGlobalObject() as { [key: string]: any };
     const proto = global[target] && global[target].prototype;
 
@@ -122,6 +126,7 @@ export class TryCatch implements Integration {
       original: () => void,
     ): (eventName: string, fn: EventListenerObject, options?: boolean | AddEventListenerOptions) => void {
       return function(
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
         this: any,
         eventName: string,
         fn: EventListenerObject,
@@ -149,6 +154,7 @@ export class TryCatch implements Integration {
         return original.call(
           this,
           eventName,
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
           wrap((fn as any) as WrappedFunction, {
             mechanism: {
               data: {
@@ -167,8 +173,10 @@ export class TryCatch implements Integration {
 
     fill(proto, 'removeEventListener', function(
       original: () => void,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
     ): (this: any, eventName: string, fn: EventListenerObject, options?: boolean | EventListenerOptions) => () => void {
       return function(
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
         this: any,
         eventName: string,
         fn: EventListenerObject,
@@ -203,13 +211,16 @@ export class TryCatch implements Integration {
 
   /** JSDoc */
   private _wrapXHR(originalSend: () => void): () => void {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     return function(this: XMLHttpRequest, ...args: any[]): void {
-      const xhr = this; // tslint:disable-line:no-this-assignment
+      // eslint-disable-next-line @typescript-eslint/no-this-alias
+      const xhr = this;
       const xmlHttpRequestProps: XMLHttpRequestProp[] = ['onload', 'onerror', 'onprogress', 'onreadystatechange'];
 
       xmlHttpRequestProps.forEach(prop => {
         if (prop in xhr && typeof xhr[prop] === 'function') {
-          fill(xhr, prop, function(original: WrappedFunction): Function {
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+          fill(xhr, prop, function(original: WrappedFunction): () => any {
             const wrapOptions = {
               mechanism: {
                 data: {

packages/browser/src/integrations/useragent.ts

@@ -14,7 +14,7 @@ export class UserAgent implements Integration {
   /**
    * @inheritDoc
    */
-  public static id: string = 'UserAgent';
+  public static id = 'UserAgent';
 
   /**
    * @inheritDoc