ref(core): Remove startTransaction & finishTransaction hooks

They are no longer needed/used.

Author: mydea

packages/core/src/baseclient.ts

@@ -417,12 +417,6 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
   // Keep on() & emit() signatures in sync with types' client.ts interface
   /* eslint-disable @typescript-eslint/unified-signatures */
 
-  /** @inheritdoc */
-  public on(hook: 'startTransaction', callback: (transaction: Transaction) => void): void;
-
-  /** @inheritdoc */
-  public on(hook: 'finishTransaction', callback: (transaction: Transaction) => void): void;
-
   /** @inheritdoc */
   public on(hook: 'spanStart', callback: (span: Span) => void): void;
 
@@ -476,12 +470,6 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
     this._hooks[hook].push(callback);
   }
 
-  /** @inheritdoc */
-  public emit(hook: 'startTransaction', transaction: Transaction): void;
-
-  /** @inheritdoc */
-  public emit(hook: 'finishTransaction', transaction: Transaction): void;
-
   /** @inheritdoc */
   public emit(hook: 'spanStart', span: Span): void;
 

packages/core/src/tracing/hubextensions.ts

@@ -43,7 +43,6 @@ function _startTransaction(
     ...customSamplingContext,
   });
   if (client) {
-    client.emit('startTransaction', transaction);
     client.emit('spanStart', transaction);
   }
   return transaction;

packages/core/src/tracing/transaction.ts

@@ -225,9 +225,6 @@ export class Transaction extends SentrySpan implements TransactionInterface {
 
     // eslint-disable-next-line deprecation/deprecation
     const client = this._hub.getClient();
-    if (client) {
-      client.emit('finishTransaction', this);
-    }
 
     if (this._sampled !== true) {
       // At this point if `sampled !== true` we want to discard the transaction.

packages/core/test/lib/base.test.ts

@@ -1935,20 +1935,6 @@ describe('BaseClient', () => {
     ] as const;
 
     describe.each(scenarios)('with client %s', (_, client) => {
-      it('should call a startTransaction hook', () => {
-        expect.assertions(1);
-
-        const mockTransaction = {
-          traceId: '86f39e84263a4de99c326acab3bfe3bd',
-        } as Transaction;
-
-        client.on('startTransaction', transaction => {
-          expect(transaction).toEqual(mockTransaction);
-        });
-
-        client.emit('startTransaction', mockTransaction);
-      });
-
       it('should call a beforeEnvelope hook', () => {
         expect.assertions(1);
 

packages/replay/src/replay.ts

@@ -3,11 +3,13 @@ import { EventType, record } from '@sentry-internal/rrweb';
 import {
   SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
   captureException,
+  getActiveSpan,
   getClient,
   getCurrentScope,
+  getRootSpan,
   spanToJSON,
 } from '@sentry/core';
-import type { ReplayRecordingMode, Transaction } from '@sentry/types';
+import type { ReplayRecordingMode, Span, Transaction } from '@sentry/types';
 import { logger } from '@sentry/utils';
 
 import {
@@ -87,10 +89,10 @@ export class ReplayContainer implements ReplayContainerInterface {
   public recordingMode: ReplayRecordingMode;
 
   /**
-   * The current or last active transcation.
+   * The current or last active span.
    * This is only available when performance is enabled.
    */
-  public lastTransaction?: Transaction;
+  public lastActiveSpan?: Span;
 
   /**
    * These are here so we can overwrite them in tests etc.
@@ -720,16 +722,16 @@ export class ReplayContainer implements ReplayContainerInterface {
    * This is only available if performance is enabled, and if an instrumented router is used.
    */
   public getCurrentRoute(): string | undefined {
-    // eslint-disable-next-line deprecation/deprecation
-    const lastTransaction = this.lastTransaction || getCurrentScope().getTransaction();
+    const lastActiveSpan = this.lastActiveSpan || getActiveSpan();
+    const lastRootSpan = lastActiveSpan && getRootSpan(lastActiveSpan);
 
-    const attributes = (lastTransaction && spanToJSON(lastTransaction).data) || {};
+    const attributes = (lastRootSpan && spanToJSON(lastRootSpan).data) || {};
     const source = attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE];
-    if (!lastTransaction || !source || !['route', 'custom'].includes(source)) {
+    if (!lastRootSpan || !source || !['route', 'custom'].includes(source)) {
       return undefined;
     }
 
-    return spanToJSON(lastTransaction).description;
+    return spanToJSON(lastRootSpan).description;
   }
 
   /**

packages/types/src/client.ts

@@ -185,18 +185,6 @@ export interface Client<O extends ClientOptions = ClientOptions> {
   // HOOKS
   /* eslint-disable @typescript-eslint/unified-signatures */
 
-  /**
-   * Register a callback for transaction start.
-   * Receives the transaction as argument.
-   */
-  on(hook: 'startTransaction', callback: (transaction: Transaction) => void): void;
-
-  /**
-   * Register a callback for transaction finish.
-   * Receives the transaction as argument.
-   */
-  on(hook: 'finishTransaction', callback: (transaction: Transaction) => void): void;
-
   /**
    * Register a callback for whenever a span is started.
    * Receives the span as argument.
@@ -278,18 +266,6 @@ export interface Client<O extends ClientOptions = ClientOptions> {
    */
   on(hook: 'close', callback: () => void): void;
 
-  /**
-   * Fire a hook event for transaction start.
-   * Expects to be given a transaction as the second argument.
-   */
-  emit(hook: 'startTransaction', transaction: Transaction): void;
-
-  /**
-   * Fire a hook event for transaction finish.
-   * Expects to be given a transaction as the second argument.
-   */
-  emit(hook: 'finishTransaction', transaction: Transaction): void;
-
   /** Fire a hook whener a span starts. */
   emit(hook: 'spanStart', span: Span): void;