ref(dev): Run linter on scripts (#4834)

lobsterkatie · web-flow · commit 55425185f12a · 2022-03-31T23:30:19.000Z
Because SDK developers running Windows [can't run our bash scripts[1], we recently decided to move to using TypeScript instead. To make this easier, this extends the domain of our `eslint` and `prettier` checks to include all `scripts` folders. It also fixes a few linting errors which doing so brought to light. [1] #4720
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -10,16 +10,7 @@ module.exports = {
     ecmaVersion: 2018,
   },
   extends: ['@sentry-internal/sdk'],
-  ignorePatterns: [
-    'coverage/**',
-    'build/**',
-    'dist/**',
-    'esm/**',
-    'examples/**',
-    'scripts/**',
-    'test/manual/**',
-    'types/**',
-  ],
+  ignorePatterns: ['coverage/**', 'build/**', 'dist/**', 'esm/**', 'examples/**', 'test/manual/**', 'types/**'],
   overrides: [
     {
       files: ['*.ts', '*.tsx', '*.d.ts'],
diff --git a/packages/angular/package.json b/packages/angular/package.json
@@ -50,11 +50,11 @@
     "clean": "rimraf dist esm build coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\""
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\""
   },
   "volta": {
     "extends": "../../package.json"
diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -63,11 +63,11 @@
     "clean": "rimraf build coverage .rpt2_cache",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "size:check": "run-p size:check:es5 size:check:es6",
     "size:check:es5": "cat build/bundles/bundle.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES5: \",$1,\"kB\";}'",
     "size:check:es6": "cat build/bundles/bundle.es6.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print \"ES6: \",$1,\"kB\";}'",
diff --git a/packages/browser/scripts/checkbrowsers.js b/packages/browser/scripts/checkbrowsers.js
@@ -1,8 +1,10 @@
+/* eslint-disable no-console */
 // Script which checks all browsers in test/integration/browser.js against supported BrowserStack browsers
 // Meant to be run manually, by running `yarn test:integration:checkbrowsers` from the command line
 
 const btoa = require('btoa');
 const fetch = require('node-fetch');
+
 const localConfigs = require('../test/integration/browsers.js');
 
 const browserstackUsername = process.env.BROWSERSTACK_USERNAME;
@@ -78,6 +80,7 @@ const checkLocalConfigsVsBrowserStack = (localConfigs, bsConfigs) => {
   const realMobileUpdates = [];
 
   // check each local config against the entire collection of BS configs
+  // eslint-disable-next-line guard-for-in
   for (const configName in localConfigs) {
     const localConfig = localConfigs[configName];
 
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -40,11 +40,11 @@
     "clean": "rimraf dist esm coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch",
     "version": "node ../../scripts/versionbump.js src/version.ts"
diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json
@@ -51,11 +51,11 @@
     "clean": "rimraf dist esm build coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch"
   },
diff --git a/packages/hub/package.json b/packages/hub/package.json
@@ -37,11 +37,11 @@
     "clean": "rimraf dist esm coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "build:npm": "npm pack",
     "test": "jest",
     "test:watch": "jest --watch"
diff --git a/packages/integrations/package.json b/packages/integrations/package.json
@@ -43,11 +43,11 @@
     "clean": "rimraf dist esm build coverage .rpt2_cache",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch"
   },
diff --git a/packages/minimal/package.json b/packages/minimal/package.json
@@ -37,11 +37,11 @@
     "clean": "rimraf dist esm coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "build:npm": "npm pack",
     "test": "jest",
     "test:watch": "jest --watch"
diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json
@@ -60,11 +60,11 @@
     "clean": "rimraf dist esm coverage *.js *.js.map *.d.ts",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "run-s test:unit",
     "test:all": "run-s test:unit test:integration",
     "test:unit": "jest",
diff --git a/packages/node/package.json b/packages/node/package.json
@@ -51,11 +51,11 @@
     "clean": "rimraf dist esm coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "run-s test:jest test:express test:webpack test:release-health",
     "test:express": "node test/manual/express-scope-separation/start.js",
     "test:jest": "jest",
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -66,11 +66,11 @@
     "clean": "rimraf dist esm build coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch"
   },
diff --git a/packages/serverless/package.json b/packages/serverless/package.json
@@ -57,11 +57,11 @@
     "clean": "rimraf dist esm build dist-awslambda-layer coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch"
   },
diff --git a/packages/serverless/scripts/build-awslambda-layer.js b/packages/serverless/scripts/build-awslambda-layer.js
@@ -11,7 +11,7 @@ const readPkg = require('read-pkg');
 const serverlessPackage = require('../package.json');
 
 if (!process.env.GITHUB_ACTIONS) {
-  console.log(`Skipping build-awslambda-layer script in local environment.`);
+  console.log('Skipping build-awslambda-layer script in local environment.');
   process.exit(0);
 }
 
diff --git a/packages/tracing/package.json b/packages/tracing/package.json
@@ -48,11 +48,11 @@
     "circularDepCheck": "madge --circular src/index.ts",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch"
   },
diff --git a/packages/types/package.json b/packages/types/package.json
@@ -32,10 +32,10 @@
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\""
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\""
   },
   "volta": {
     "extends": "../../package.json"
diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -41,11 +41,11 @@
     "clean": "rimraf dist esm coverage *.js *.js.map *.d.ts",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch",
     "test:package": "node test/types/index.js"
diff --git a/packages/vue/package.json b/packages/vue/package.json
@@ -49,11 +49,11 @@
     "clean": "rimraf dist esm build coverage",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "jest",
     "test:watch": "jest --watch"
   },
diff --git a/packages/wasm/package.json b/packages/wasm/package.json
@@ -48,11 +48,11 @@
     "clean": "rimraf dist esm coverage *.js.map *.d.ts",
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
-    "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
+    "fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
     "link:yarn": "yarn link",
     "lint": "run-s lint:prettier lint:eslint",
     "lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
-    "lint:prettier": "prettier --check \"{src,test}/**/*.ts\"",
+    "lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
     "test": "node test/scripts/ensure-browser-bundle.js && cross-env PORT=1337 jest",
     "test:watch": "jest --watch"
   },
diff --git a/scripts/test.ts b/scripts/test.ts
@@ -1,11 +1,11 @@
-const { spawnSync } = require('child_process');
-const { join } = require('path');
+import { spawnSync } from 'child_process';
+import { join } from 'path';
 
-function run(cmd: string, cwd = '') {
+function run(cmd: string, cwd: string = '') {
   const result = spawnSync(cmd, { shell: true, stdio: 'inherit', cwd: join(__dirname, '..', cwd || '') });
 
   if (result.status !== 0) {
-    process.exit(result.status);
+    process.exit(result.status || undefined);
   }
 }
 
