Skip to content

Commit 5462b04

Browse files
author
Luca Forstner
authored
build: Re-enable eslint no-unused-vars, no-control-regex and no-loss-of-precision (#10049)
1 parent 8fdf340 commit 5462b04

File tree

11 files changed

+24
-44
lines changed

11 files changed

+24
-44
lines changed

‎.eslintrc.js‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,23 +23,11 @@ module.exports = {
2323
'types/**',
2424
],
2525
overrides: [
26-
{
27-
files: ['*'],
28-
rules: {
29-
// Disabled because it's included with Biome's linter
30-
'no-control-regex': 'off',
31-
},
32-
},
3326
{
3427
files: ['*.ts', '*.tsx', '*.d.ts'],
3528
parserOptions: {
3629
project: ['tsconfig.json'],
3730
},
38-
rules: {
39-
// Disabled because it's included with Biome's linter
40-
'@typescript-eslint/no-unused-vars': 'off',
41-
'@typescript-eslint/no-loss-of-precision': 'off',
42-
},
4331
},
4432
{
4533
files: ['test/**/*.ts', 'test/**/*.tsx'],

‎dev-packages/browser-integration-tests/suites/public-api/startSpan/error-sync/test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ sentryTest('should capture an error within a sync startSpan callback', async ({
1313
const gotoPromise = page.goto(url);
1414
const envelopePromise = getMultipleSentryEnvelopeRequests<Event>(page, 2);
1515

16-
const [_, events] = await Promise.all([gotoPromise, envelopePromise]);
16+
const [, events] = await Promise.all([gotoPromise, envelopePromise]);
1717
const txn = events.find(event => event.type === 'transaction');
1818
const err = events.find(event => !event.type);
1919

‎dev-packages/node-integration-tests/suites/anr/test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ conditionalTest({ min: 16 })('should report ANR when event loop blocked', () =>
124124
done();
125125
}, 5_000);
126126

127-
childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, (_, stdout) => {
127+
childProcess.exec(`node ${testScriptPath}`, { encoding: 'utf8' }, () => {
128128
hasClosed = true;
129129
});
130130
});

‎packages/core/test/lib/exports.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@ describe('withScope', () => {
3535
});
3636

3737
it('works with a return value', () => {
38-
const res = withScope(scope => {
38+
const res = withScope(() => {
3939
return 'foo';
4040
});
4141

4242
expect(res).toBe('foo');
4343
});
4444

4545
it('works with an async function return value', async () => {
46-
const res = withScope(async scope => {
46+
const res = withScope(async () => {
4747
return 'foo';
4848
});
4949

‎packages/core/test/lib/utils/applyScopeDataToEvent.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,9 @@ describe('mergeScopeData', () => {
156156
const breadcrumb2 = { message: '2' } as Breadcrumb;
157157
const breadcrumb3 = { message: '3' } as Breadcrumb;
158158

159-
const eventProcessor1 = ((a: unknown) => null) as EventProcessor;
160-
const eventProcessor2 = ((b: unknown) => null) as EventProcessor;
161-
const eventProcessor3 = ((c: unknown) => null) as EventProcessor;
159+
const eventProcessor1 = (() => null) as EventProcessor;
160+
const eventProcessor2 = (() => null) as EventProcessor;
161+
const eventProcessor3 = (() => null) as EventProcessor;
162162

163163
const data1: ScopeData = {
164164
eventProcessors: [eventProcessor1],

‎packages/node/src/cron/node-cron.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export function instrumentNodeCron<T>(lib: Partial<NodeCron> & T): T {
3535
// When 'get' is called for schedule, return a proxied version of the schedule function
3636
return new Proxy(target.schedule, {
3737
apply(target, thisArg, argArray: Parameters<NodeCron['schedule']>) {
38-
const [expression, _, options] = argArray;
38+
const [expression, , options] = argArray;
3939

4040
if (!options?.name) {
4141
throw new Error('Missing "name" for scheduled job. A name is required for Sentry check-in monitoring.');

‎packages/node/test/cron.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe('cron check-ins', () => {
5353

5454
const CronJobWithCheckIn = cron.instrumentCron(CronJobMock, 'my-cron-job');
5555

56-
const _ = new CronJobWithCheckIn('* * * Jan,Sep Sun', () => {
56+
new CronJobWithCheckIn('* * * Jan,Sep Sun', () => {
5757
expect(withMonitorSpy).toHaveBeenCalledTimes(1);
5858
expect(withMonitorSpy).toHaveBeenLastCalledWith('my-cron-job', expect.anything(), {
5959
schedule: { type: 'crontab', value: '* * * 1,9 0' },
@@ -67,7 +67,7 @@ describe('cron check-ins', () => {
6767

6868
const CronJobWithCheckIn = cron.instrumentCron(CronJobMock, 'my-cron-job');
6969

70-
const _ = CronJobWithCheckIn.from({
70+
CronJobWithCheckIn.from({
7171
cronTime: '* * * Jan,Sep Sun',
7272
onTick: () => {
7373
expect(withMonitorSpy).toHaveBeenCalledTimes(1);

‎packages/opentelemetry/src/custom/client.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export function wrapClientClass<
7171
event: Event,
7272
hint: EventHint,
7373
scope?: Scope,
74-
isolationScope?: Scope,
74+
_isolationScope?: Scope,
7575
): PromiseLike<Event | null> {
7676
let actualScope = scope;
7777

‎packages/opentelemetry/src/spanProcessor.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { maybeCaptureExceptionForTimedEvent } from './utils/captureExceptionForT
1212
import { getHubFromContext } from './utils/contextData';
1313
import { getSpanHub, setSpanFinishScope, setSpanHub, setSpanParent, setSpanScope } from './utils/spanData';
1414

15-
function onSpanStart(span: Span, parentContext: Context, ScopeClass: typeof OpenTelemetryScope): void {
15+
function onSpanStart(span: Span, parentContext: Context, _ScopeClass: typeof OpenTelemetryScope): void {
1616
// This is a reliable way to get the parent span - because this is exactly how the parent is identified in the OTEL SDK
1717
const parentSpan = trace.getSpan(parentContext);
1818
const hub = getHubFromContext(parentContext);

‎packages/serverless/test/awslambda.test.ts‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,7 @@ const fakeCallback: Callback = (err, result) => {
3939
return err;
4040
};
4141

42-
function expectScopeSettings(fakeTransactionContext: any) {
43-
// @ts-expect-error see "Why @ts-expect-error" note
44-
const fakeSpan = { ...SentryNode.fakeSpan, ...fakeTransactionContext };
42+
function expectScopeSettings() {
4543
// @ts-expect-error see "Why @ts-expect-error" note
4644
expect(SentryNode.fakeScope.setTransactionName).toBeCalledWith('functionName');
4745
// @ts-expect-error see "Why @ts-expect-error" note
@@ -213,7 +211,7 @@ describe('AWSLambda', () => {
213211

214212
expect(rv).toStrictEqual(42);
215213
expect(SentryNode.startSpanManual).toBeCalledWith(fakeTransactionContext, expect.any(Function));
216-
expectScopeSettings(fakeTransactionContext);
214+
expectScopeSettings();
217215
// @ts-expect-error see "Why @ts-expect-error" note
218216
expect(SentryNode.fakeSpan.end).toBeCalled();
219217
expect(SentryNode.flush).toBeCalledWith(2000);
@@ -239,7 +237,7 @@ describe('AWSLambda', () => {
239237
};
240238

241239
expect(SentryNode.startSpanManual).toBeCalledWith(fakeTransactionContext, expect.any(Function));
242-
expectScopeSettings(fakeTransactionContext);
240+
expectScopeSettings();
243241
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
244242
// @ts-expect-error see "Why @ts-expect-error" note
245243
expect(SentryNode.fakeSpan.end).toBeCalled();
@@ -317,7 +315,7 @@ describe('AWSLambda', () => {
317315
};
318316

319317
expect(SentryNode.startSpanManual).toBeCalledWith(fakeTransactionContext, expect.any(Function));
320-
expectScopeSettings(fakeTransactionContext);
318+
expectScopeSettings();
321319
expect(SentryNode.captureException).toBeCalledWith(e, expect.any(Function));
322320
// @ts-expect-error see "Why @ts-expect-error" note
323321
expect(SentryNode.fakeSpan.end).toBeCalled();
@@ -345,7 +343,7 @@ describe('AWSLambda', () => {
345343

346344
expect(rv).toStrictEqual(42);
347345
expect(SentryNode.startSpanManual).toBeCalledWith(fakeTransactionContext, expect.any(Function));
348-
expectScopeSettings(fakeTransactionContext);
346+
expectScopeSettings();
349347
// @ts-expect-error see "Why @ts-expect-error" note
350348
expect(SentryNode.fakeSpan.end).toBeCalled();
351349
expect(SentryNode.flush).toBeCalled();
@@ -382,7 +380,7 @@ describe('AWSLambda', () => {
382380
};
383381

384382
expect(SentryNode.startSpanManual).toBeCalledWith(fakeTransactionContext, expect.any(Function));
385-
expectScopeSettings(fakeTransactionContext);
383+
expectScopeSettings();
386384
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
387385
// @ts-expect-error see "Why @ts-expect-error" note
388386
expect(SentryNode.fakeSpan.end).toBeCalled();
@@ -425,7 +423,7 @@ describe('AWSLambda', () => {
425423

426424
expect(rv).toStrictEqual(42);
427425
expect(SentryNode.startSpanManual).toBeCalledWith(fakeTransactionContext, expect.any(Function));
428-
expectScopeSettings(fakeTransactionContext);
426+
expectScopeSettings();
429427
// @ts-expect-error see "Why @ts-expect-error" note
430428
expect(SentryNode.fakeSpan.end).toBeCalled();
431429
expect(SentryNode.flush).toBeCalled();
@@ -462,7 +460,7 @@ describe('AWSLambda', () => {
462460
};
463461

464462
expect(SentryNode.startSpanManual).toBeCalledWith(fakeTransactionContext, expect.any(Function));
465-
expectScopeSettings(fakeTransactionContext);
463+
expectScopeSettings();
466464
expect(SentryNode.captureException).toBeCalledWith(error, expect.any(Function));
467465
// @ts-expect-error see "Why @ts-expect-error" note
468466
expect(SentryNode.fakeSpan.end).toBeCalled();

0 commit comments

Comments
 (0)