Skip to content

Commit 51ceb94

Browse files
authored
Merge branch 'develop' into abhi-vue-deprecations
2 parents f4c3046 + 9307308 commit 51ceb94

File tree

101 files changed

+159
-2830
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+159
-2830
lines changed

.github/ISSUE_TEMPLATE/flaky.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ body:
1818
id: job-name
1919
attributes:
2020
label: Name of Job
21-
placeholder: Build & Test / Nextjs (Node 10) Tests
21+
placeholder: Build & Test / Nextjs (Node 14) Tests
2222
description: name of job as reported in the status report
2323
validations:
2424
required: true

.github/workflows/build.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ jobs:
523523
strategy:
524524
fail-fast: false
525525
matrix:
526-
node: [8, 10, 12, 14, 16, 18, 20, 21]
526+
node: [14, 16, 18, 20, 21]
527527
steps:
528528
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
529529
uses: actions/checkout@v4
@@ -540,9 +540,7 @@ jobs:
540540
- name: Run tests
541541
env:
542542
NODE_VERSION: ${{ matrix.node }}
543-
run: |
544-
[[ $NODE_VERSION == 8 ]] && yarn add --dev --ignore-engines --ignore-scripts --ignore-workspace-root-check [email protected]
545-
yarn test-ci-node
543+
run: yarn test-ci-node
546544
- name: Compute test coverage
547545
uses: codecov/codecov-action@v4
548546
with:
@@ -585,7 +583,7 @@ jobs:
585583
strategy:
586584
fail-fast: false
587585
matrix:
588-
node: [10, 12, 14, 16, 18, 20, 21]
586+
node: [14, 16, 18, 20, 21]
589587
steps:
590588
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
591589
uses: actions/checkout@v4
@@ -612,12 +610,12 @@ jobs:
612610
path: ${{ steps.npm-cache-dir.outputs.dir }}
613611
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
614612
- name: Install Playwright browser if not cached
615-
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
613+
if: steps.playwright-cache.outputs.cache-hit != 'true'
616614
run: npx playwright install --with-deps
617615
env:
618616
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
619617
- name: Install OS dependencies of Playwright if cache hit
620-
if: steps.playwright-cache.outputs.cache-hit == 'true' && matrix.node >= 14
618+
if: steps.playwright-cache.outputs.cache-hit == 'true'
621619
run: npx playwright install-deps
622620
- name: Run tests
623621
env:
@@ -874,7 +872,7 @@ jobs:
874872
strategy:
875873
fail-fast: false
876874
matrix:
877-
node: [10, 12, 14, 16, 18, 20, 21]
875+
node: [14, 16, 18, 20, 21]
878876
typescript:
879877
- false
880878
include:

MIGRATION.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
# Upgrading from 7.x to 8.x
2+
3+
## Removal of Severity Enum
4+
5+
In v7 we deprecated the `Severity` enum in favor of using the `SeverityLevel` type. In v8 we removed the `Severity`
6+
enum. If you were using the `Severity` enum, you should replace it with the `SeverityLevel` type. See
7+
[below](#severity-severitylevel-and-severitylevels) for code snippet examples
8+
9+
## Removal of the `Offline` integration
10+
11+
The `Offline` integration has been removed in favor of the offline transport wrapper:
12+
http://docs.sentry.io/platforms/javascript/configuration/transports/#offline-caching
13+
114
# Deprecations in 7.x
215

316
You can use the **Experimental** [@sentry/migr8](https://www.npmjs.com/package/@sentry/migr8) to automatically update

dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,14 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr
2828

2929
// Ensure window.open() still works as expected
3030
const context = browser.contexts()[0];
31-
const waitForNewPage = context.waitForEvent('page');
3231

33-
await page.locator('#windowOpenButton').click();
32+
const [reqResponse1] = await Promise.all([
33+
reqPromise1,
34+
context.waitForEvent('page'),
35+
page.locator('#windowOpenButton').click(),
36+
]);
3437

35-
const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1);
38+
const { breadcrumbs } = getCustomRecordingEvents(reqResponse1);
3639

3740
// Filter out potential blur breadcrumb, as otherwise this can be flaky
3841
const filteredBreadcrumb = breadcrumbs.filter(breadcrumb => breadcrumb.category !== 'ui.blur');
@@ -57,8 +60,6 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr
5760
},
5861
]);
5962

60-
await waitForNewPage;
61-
6263
const pages = context.pages();
6364

6465
expect(pages.length).toBe(2);

dev-packages/browser-integration-tests/suites/wasm/init.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import * as Sentry from '@sentry/browser';
2-
import { Wasm } from '@sentry/wasm';
2+
import { wasmIntegration } from '@sentry/wasm';
33

44
window.Sentry = Sentry;
55

66
Sentry.init({
77
dsn: 'https://[email protected]/1337',
8-
integrations: [new Wasm()],
8+
integrations: [wasmIntegration()],
99
beforeSend: event => {
1010
window.events.push(event);
1111
return null;

dev-packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/src/index.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import * as Sentry from '@sentry/react';
2-
import { BrowserTracing } from '@sentry/tracing';
32
import React from 'react';
43
import ReactDOM from 'react-dom/client';
54
import {
@@ -18,14 +17,12 @@ Sentry.init({
1817
environment: 'qa', // dynamic sampling bias to keep transactions
1918
dsn: process.env.REACT_APP_E2E_TEST_DSN,
2019
integrations: [
21-
new BrowserTracing({
22-
routingInstrumentation: Sentry.reactRouterV6Instrumentation(
23-
React.useEffect,
24-
useLocation,
25-
useNavigationType,
26-
createRoutesFromChildren,
27-
matchRoutes,
28-
),
20+
Sentry.reactRouterV6BrowserTracingIntegration({
21+
useEffect: React.useEffect,
22+
useLocation,
23+
useNavigationType,
24+
createRoutesFromChildren,
25+
matchRoutes,
2926
}),
3027
],
3128
// We recommend adjusting this value in production, or using tracesSampler

dev-packages/node-integration-tests/suites/express/tracing-experimental/test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { conditionalTest } from '../../../utils';
21
import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
32

4-
conditionalTest({ min: 14 })('express tracing experimental', () => {
3+
describe('express tracing experimental', () => {
54
afterAll(() => {
65
cleanupChildProcesses();
76
});

dev-packages/node-integration-tests/suites/tracing-experimental/apollo-graphql/test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { conditionalTest } from '../../../utils';
21
import { createRunner } from '../../../utils/runner';
32

4-
conditionalTest({ min: 14 })('GraphQL/Apollo Tests', () => {
3+
describe('GraphQL/Apollo Tests', () => {
54
test('CJS - should instrument GraphQL queries used from Apollo Server.', done => {
65
const EXPECTED_TRANSACTION = {
76
transaction: 'Test Transaction',

dev-packages/node-integration-tests/suites/tracing-experimental/hapi/test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import { conditionalTest } from '../../../utils';
21
import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
32

43
jest.setTimeout(20000);
54

6-
conditionalTest({ min: 14 })('hapi auto-instrumentation', () => {
5+
describe('hapi auto-instrumentation', () => {
76
afterAll(async () => {
87
cleanupChildProcesses();
98
});

dev-packages/node-integration-tests/suites/tracing-experimental/mongodb/test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
import { MongoMemoryServer } from 'mongodb-memory-server-global';
22

3-
import { conditionalTest } from '../../../utils';
43
import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
54

65
jest.setTimeout(20000);
76

8-
conditionalTest({ min: 14 })('MongoDB experimental Test', () => {
7+
describe('MongoDB experimental Test', () => {
98
let mongoServer: MongoMemoryServer;
109

1110
beforeAll(async () => {

0 commit comments

Comments
 (0)