meta(utils): Replace custom versionbump script with rollup replace plugin (#14340)

Author: Luca Forstner

.github/workflows/build.yml

@@ -44,7 +44,6 @@ env:
     ${{ github.workspace }}/packages/*/build
     ${{ github.workspace }}/packages/ember/*.d.ts
     ${{ github.workspace }}/packages/gatsby/*.d.ts
-    ${{ github.workspace }}/packages/core/src/version.ts
     ${{ github.workspace }}/packages/utils/cjs
     ${{ github.workspace }}/packages/utils/esm
 

packages/core/test/lib/carrier.test.ts

@@ -42,14 +42,13 @@ describe('getSentryCarrier', () => {
   describe('multiple (older) SDKs', () => {
     it("returns the version of the sentry carrier object of the SDK's version rather than the one set in .version", () => {
       const sentryCarrier = getSentryCarrier({
+        // @ts-expect-error - this is just a test object
         __SENTRY__: {
-          version: '8.0.0' as const, // another SDK set this
+          version: '8.0.0', // another SDK set this
           '8.0.0': {
-            // @ts-expect-error - this is just a test object, not passing a full stack
             stack: {},
           },
           [SDK_VERSION]: {
-            // @ts-expect-error - this is just a test object, not passing a full ACS
             acs: {},
           },
           hub: {},

packages/utils/.eslintrc.js

@@ -15,5 +15,5 @@ module.exports = {
     },
   ],
   // symlinks to the folders inside of `build`, created to simulate what's in the npm package
-  ignorePatterns: ['cjs/**', 'esm/**'],
+  ignorePatterns: ['cjs/**', 'esm/**', 'rollup.npm.config.mjs'],
 };

packages/utils/package.json

@@ -63,7 +63,6 @@
     "lint": "eslint . --format stylish",
     "test": "jest",
     "test:watch": "jest --watch",
-    "version": "node ../../scripts/versionbump.js src/version.ts",
     "yalc:publish": "yalc publish --push --sig"
   },
   "volta": {

packages/utils/rollup.npm.config.mjs

@@ -1,4 +1,6 @@
+import replace from '@rollup/plugin-replace';
 import { makeBaseNPMConfig, makeNPMConfigVariants } from '@sentry-internal/rollup-utils';
+import packageJson from './package.json' with { type: 'json' };
 
 export default makeNPMConfigVariants(
   makeBaseNPMConfig({
@@ -12,6 +14,14 @@ export default makeNPMConfigVariants(
             ? true
             : Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
       },
+      plugins: [
+        replace({
+          preventAssignment: true,
+          values: {
+            __SENTRY_SDK_VERSION__: JSON.stringify(packageJson.version),
+          },
+        }),
+      ],
     },
   }),
 );

packages/utils/src/version.ts

@@ -1 +1,4 @@
-export const SDK_VERSION = '8.38.0';
+// This is a magic string replaced by rollup
+declare const __SENTRY_SDK_VERSION__: string;
+
+export const SDK_VERSION = typeof __SENTRY_SDK_VERSION__ === 'string' ? __SENTRY_SDK_VERSION__ : '0.0.0-unknown.0';