feat: Remove tags from spans & transactions (#10809)

We've refactored all usage away, now we can actually get rid of the tags
on the span themselves.

Author: mydea

packages/core/src/tracing/sentrySpan.ts

@@ -1,5 +1,4 @@
 import type {
-  Primitive,
   Span,
   SpanAttributeValue,
   SpanAttributes,
@@ -65,12 +64,6 @@ export class SpanRecorder {
  * Span contains all data about a span
  */
 export class SentrySpan implements Span {
-  /**
-   * Tags for the span.
-   * @deprecated Use `spanToJSON(span).atttributes` instead.
-   */
-  public tags: { [key: string]: Primitive };
-
   /**
    * Data for the span.
    * @deprecated Use `spanToJSON(span).atttributes` instead.
@@ -117,8 +110,6 @@ export class SentrySpan implements Span {
     this._spanId = spanContext.spanId || uuid4().substring(16);
     this._startTime = spanContext.startTimestamp || timestampInSeconds();
     // eslint-disable-next-line deprecation/deprecation
-    this.tags = spanContext.tags ? { ...spanContext.tags } : {};
-    // eslint-disable-next-line deprecation/deprecation
     this.data = spanContext.data ? { ...spanContext.data } : {};
 
     this._attributes = {};
@@ -328,21 +319,6 @@ export class SentrySpan implements Span {
     return childSpan;
   }
 
-  /**
-   * Sets the tag attribute on the current span.
-   *
-   * Can also be used to unset a tag, by passing `undefined`.
-   *
-   * @param key Tag key
-   * @param value Tag value
-   * @deprecated Use `setAttribute()` instead.
-   */
-  public setTag(key: string, value: Primitive): this {
-    // eslint-disable-next-line deprecation/deprecation
-    this.tags = { ...this.tags, [key]: value };
-    return this;
-  }
-
   /**
    * Sets the data attribute on the current span
    * @param key Data key
@@ -439,8 +415,6 @@ export class SentrySpan implements Span {
       spanId: this._spanId,
       startTimestamp: this._startTime,
       status: this._status,
-      // eslint-disable-next-line deprecation/deprecation
-      tags: this.tags,
       traceId: this._traceId,
     });
   }
@@ -471,8 +445,6 @@ export class SentrySpan implements Span {
       span_id: this._spanId,
       start_timestamp: this._startTime,
       status: getStatusMessage(this._status),
-      // eslint-disable-next-line deprecation/deprecation
-      tags: Object.keys(this.tags).length > 0 ? this.tags : undefined,
       timestamp: this._endTime,
       trace_id: this._traceId,
       origin: this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,

packages/core/src/tracing/transaction.ts

@@ -286,8 +286,6 @@ export class Transaction extends SentrySpan implements TransactionInterface {
       },
       spans,
       start_timestamp: this._startTime,
-      // eslint-disable-next-line deprecation/deprecation
-      tags: this.tags,
       timestamp: this._endTime,
       transaction: this._name,
       type: 'transaction',

packages/core/src/utils/spanUtils.ts

@@ -22,15 +22,14 @@ export const TRACE_FLAG_SAMPLED = 0x1;
  */
 export function spanToTraceContext(span: Span): TraceContext {
   const { spanId: span_id, traceId: trace_id } = span.spanContext();
-  const { data, op, parent_span_id, status, tags, origin } = spanToJSON(span);
+  const { data, op, parent_span_id, status, origin } = spanToJSON(span);
 
   return dropUndefinedKeys({
     data,
     op,
     parent_span_id,
     span_id,
     status,
-    tags,
     trace_id,
     origin,
   });

packages/profiling-node/test/hubextensions.test.ts

@@ -15,7 +15,6 @@ import { __PRIVATE__wrapStartTransactionWithProfiling } from '../src/hubextensio
 function makeTransactionMock(options = {}): Transaction {
   return {
     metadata: {},
-    tags: {},
     sampled: true,
     contexts: {},
     startChild: () => ({ end: () => void 0 }),
@@ -29,10 +28,6 @@ function makeTransactionMock(options = {}): Transaction {
       // @ts-expect-error - contexts is private
       this.contexts[key] = context;
     },
-    setTag(this: Transaction, key: string, value: any) {
-      // eslint-disable-next-line deprecation/deprecation
-      this.tags[key] = value;
-    },
     setMetadata(this: Transaction, metadata: Partial<TransactionMetadata>) {
       // eslint-disable-next-line deprecation/deprecation
       this.metadata = { ...metadata } as TransactionMetadata;

packages/types/src/span.ts

@@ -50,7 +50,6 @@ export interface SpanJSON {
   span_id: string;
   start_timestamp: number;
   status?: string;
-  tags?: { [key: string]: Primitive };
   timestamp?: number;
   trace_id: string;
   origin?: SpanOrigin;
@@ -132,12 +131,6 @@ export interface SpanContext {
    */
   traceId?: string | undefined;
 
-  /**
-   * Tags of the Span.
-   * @deprecated Pass `attributes` instead.
-   */
-  tags?: { [key: string]: Primitive };
-
   /**
    * Data of the Span.
    * @deprecated Pass `attributes` instead.

packages/types/src/transaction.ts

@@ -1,7 +1,7 @@
 import type { Context } from './context';
 import type { DynamicSamplingContext } from './envelope';
 import type { MeasurementUnit } from './measurement';
-import type { ExtractedNodeRequestData, Primitive, WorkerLocation } from './misc';
+import type { ExtractedNodeRequestData, WorkerLocation } from './misc';
 import type { PolymorphicRequest } from './polymorphics';
 import type { Span, SpanAttributes, SpanContext } from './span';
 
@@ -81,12 +81,6 @@ export interface Transaction extends Omit<TransactionContext, 'name' | 'op'>, Sp
    */
   startTimestamp: number;
 
-  /**
-   * Tags for the transaction.
-   * @deprecated Use `getSpanAttributes(transaction)` instead.
-   */
-  tags: { [key: string]: Primitive };
-
   /**
    * Data for the transaction.
    * @deprecated Use `getSpanAttributes(transaction)` instead.