unskip tests which needed sampled = false transactions to be findable to work

Author: lobsterkatie

packages/tracing/test/browser/browsertracing.test.ts

@@ -178,8 +178,7 @@ describe('BrowserTracing', () => {
         expect(mockBeforeNavigation).toHaveBeenCalledTimes(1);
       });
 
-      // TODO add this back in once getTransaction() returns sampled = false transactions, too
-      it.skip('creates a transaction with sampled = false if it returns undefined', () => {
+      it('creates a transaction with sampled = false if beforeNavigate returns undefined', () => {
         const mockBeforeNavigation = jest.fn().mockReturnValue(undefined);
         createBrowserTracing(true, {
           beforeNavigate: mockBeforeNavigation,
@@ -412,8 +411,7 @@ describe('BrowserTracing', () => {
     });
 
     describe('using the data', () => {
-      // TODO add this back in once getTransaction() returns sampled = false transactions, too
-      it.skip('uses the data for pageload transactions', () => {
+      it('uses the data for pageload transactions', () => {
         // make sampled false here, so we can see that it's being used rather than the tracesSampleRate-dictated one
         document.head.innerHTML = `<meta name="sentry-trace" content="12312012123120121231201212312012-1121201211212012-0">`;
 

packages/tracing/test/hub.test.ts

@@ -44,8 +44,7 @@ describe('Hub', () => {
       expect(hub.getScope()?.getTransaction()).toBe(transaction);
     });
 
-    // TODO add this back in once getTransaction() returns sampled = false transactions, too
-    it.skip('should find a transaction which has been set on the scope if sampled = false', () => {
+    it('should find a transaction which has been set on the scope if sampled = false', () => {
       const hub = new Hub(new BrowserClient({ tracesSampleRate: 1 }));
       const transaction = hub.startTransaction({ name: 'dogpark', sampled: false });
 
@@ -384,8 +383,7 @@ describe('Hub', () => {
         expect(extractTraceparentData(headers['sentry-trace'])!.parentSampled).toBe(true);
       });
 
-      // TODO add this back in once getTransaction() returns sampled = false transactions, too
-      it.skip('should propagate negative sampling decision to child transactions in XHR header', () => {
+      it('should propagate negative sampling decision to child transactions in XHR header', () => {
         const hub = new Hub(
           new BrowserClient({
             dsn: 'https://[email protected]/1121',