fix again

Author: c298lee

packages/browser-integration-tests/suites/replay/canvas/withCanvasIntegrationFirst/test.ts

@@ -1,13 +1,15 @@
 import { expect } from '@playwright/test';
 
 import { sentryTest } from '../../../../utils/fixtures';
-import { getReplaySnapshot, shouldSkipReplayTest } from '../../../../utils/replayHelpers';
+import { getReplaySnapshot, shouldSkipReplayTest, waitForReplayRequest } from '../../../../utils/replayHelpers';
 
 sentryTest('sets up canvas when adding ReplayCanvas integration first', async ({ getLocalTestUrl, page }) => {
-  if (shouldSkipReplayTest()) {
+  if (shouldSkipReplayTest() || (process.env.PW_BUNDLE || '').startsWith('bundle')) {
     sentryTest.skip();
   }
 
+  const reqPromise0 = waitForReplayRequest(page, 0);
+
   await page.route('https://dsn.ingest.sentry.io/**/*', route => {
     return route.fulfill({
       status: 200,
@@ -19,10 +21,11 @@ sentryTest('sets up canvas when adding ReplayCanvas integration first', async ({
   const url = await getLocalTestUrl({ testDir: __dirname });
 
   await page.goto(url);
+  await reqPromise0;
 
   const replay = await getReplaySnapshot(page);
-  const canvasOptions = replay._options._experiments?.canvas;
-  expect(canvasOptions.fps).toBe(4);
-  expect(canvasOptions.quality).toBe(0.6);
+  const canvasOptions = replay._canvas;
+  expect(canvasOptions?.sampling.canvas).toBe(2);
+  expect(canvasOptions?.dataURLOptions.quality).toBe(0.4);
   expect(replay._hasCanvas).toBe(true);
 });

packages/browser-integration-tests/suites/replay/canvas/withCanvasIntegrationSecond/test.ts

@@ -1,13 +1,15 @@
 import { expect } from '@playwright/test';
 
 import { sentryTest } from '../../../../utils/fixtures';
-import { getReplaySnapshot, shouldSkipReplayTest } from '../../../../utils/replayHelpers';
+import { getReplaySnapshot, shouldSkipReplayTest, waitForReplayRequest } from '../../../../utils/replayHelpers';
 
 sentryTest('sets up canvas when adding ReplayCanvas integration after Replay', async ({ getLocalTestUrl, page }) => {
-  if (shouldSkipReplayTest()) {
+  if (shouldSkipReplayTest() || (process.env.PW_BUNDLE || '').startsWith('bundle')) {
     sentryTest.skip();
   }
 
+  const reqPromise0 = waitForReplayRequest(page, 0);
+
   await page.route('https://dsn.ingest.sentry.io/**/*', route => {
     return route.fulfill({
       status: 200,
@@ -19,10 +21,11 @@ sentryTest('sets up canvas when adding ReplayCanvas integration after Replay', a
   const url = await getLocalTestUrl({ testDir: __dirname });
 
   await page.goto(url);
+  await reqPromise0;
 
   const replay = await getReplaySnapshot(page);
-  const canvasOptions = replay._options._experiments?.canvas;
-  expect(canvasOptions.fps).toBe(4);
-  expect(canvasOptions.quality).toBe(0.6);
+  const canvasOptions = replay._canvas;
+  expect(canvasOptions?.sampling.canvas).toBe(2);
+  expect(canvasOptions?.dataURLOptions.quality).toBe(0.4);
   expect(replay._hasCanvas).toBe(true);
 });

packages/browser-integration-tests/suites/replay/canvas/withoutCanvasIntegration/test.ts

@@ -21,7 +21,7 @@ sentryTest('does not setup up canvas without ReplayCanvas integration', async ({
   await page.goto(url);
 
   const replay = await getReplaySnapshot(page);
-  const canvasOptions = replay._options._experiments?.canvas;
+  const canvasOptions = replay._canvas;
   expect(canvasOptions).toBe(undefined);
   expect(replay._hasCanvas).toBe(false);
 });

packages/types/src/client.ts

@@ -138,13 +138,13 @@ export interface Client<O extends ClientOptions = ClientOptions> {
    */
   getEventProcessors?(): EventProcessor[];
 
-   /**
+  /**
    * Returns the client's instance of the given integration class, it any.
    * @deprecated Use `getIntegrationByName()` instead.
    */
-   getIntegration<T extends Integration>(integration: IntegrationClass<T>): T | null;
+  getIntegration<T extends Integration>(integration: IntegrationClass<T>): T | null;
 
-   /** Get the instance of the integration with the given name on the client, if it was added. */
+  /** Get the instance of the integration with the given name on the client, if it was added. */
   getIntegrationByName?<T extends Integration = Integration>(name: string): T | undefined;
 
   /**