Enabling Raven.debug will log outbound request data

Author: benvinegar

src/raven.js

@@ -750,18 +750,10 @@ function makeRequest(data) {
     var img,
         src;
 
-    if (isSetup()) {
-        logDebug('debug', 'Raven about to send:', data);
-    }
-    else {
-        var ravenDebugOriginal = Raven.debug;
-        //Ugly, but now that logDebug supports variadic arguments, there is little other choice
-        //except duplicating the logDebug function.
-        Raven.debug = true;
-        logDebug('log', 'If configured, Raven would send:', data);
-        Raven.debug = ravenDebugOriginal;
-        return;
-    }
+    logDebug('debug', 'Raven about to send:', data);
+
+    if (!isSetup()) return;
+
     img = newImage();
     src = globalServer + authQueryString + '&sentry_data=' + encodeURIComponent(JSON.stringify(data));
     if (globalOptions.crossOrigin || globalOptions.crossOrigin === '') {
@@ -789,10 +781,14 @@ function newImage() {
     return document.createElement('img');
 }
 
+var ravenNotConfiguredError;
+
 function isSetup() {
     if (!hasJSON) return false;  // needs JSON support
     if (!globalServer) {
-        logDebug('error', 'Error: Raven has not been configured.');
+        if (!ravenNotConfiguredError)
+          logDebug('error', 'Error: Raven has not been configured.');
+        ravenNotConfiguredError = true;
         return false;
     }
     return true;

test/raven.test.js

@@ -19,8 +19,8 @@ function flushRavenState() {
         tags: {},
         extra: {}
     },
-    startTime = 0
-    ;
+    startTime = 0;
+    ravenNotConfiguredError = undefined;
 
     Raven.uninstall();
 }
@@ -286,17 +286,31 @@ describe('globals', function() {
     });
 
     describe('isSetup', function() {
+        beforeEach(function () {
+          this.sinon.stub(window, 'logDebug');
+        });
+
         it('should return false with no JSON support', function() {
             globalServer = 'http://localhost/';
             hasJSON = false;
             assert.isFalse(isSetup());
         });
 
-        it('should return false when Raven is not configured', function() {
-            hasJSON = true;    // be explicit
+        describe('when Raven is not configured', function () {
+          it('should return false when Raven is not configured', function() {
+              hasJSON = true;    // be explicit
+              globalServer = undefined;
+              assert.isFalse(isSetup());
+          });
+
+          it('should log an error message, the first time it is called', function () {
+            hasJSON = true;
             globalServer = undefined;
-            this.sinon.stub(window, 'logDebug');
-            assert.isFalse(isSetup());
+            isSetup();
+            isSetup();
+            assert.isTrue(window.logDebug.calledWith('error', 'Error: Raven has not been configured.'))
+            assert.isTrue(window.logDebug.calledOnce);
+          });
         });
 
         it('should return true when everything is all gravy', function() {