test: Clean up test output warnings (#14358)

This PR cleans up some jest test output:

1. Ensure we do avoid printing out some `console.error` stuff for
invalid DSN parsing.
2. Update jest config to avoid printing of these warnings you get all
the time in the tests:

```
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
ts-jest[config] (WARN) message TS151001: If you have issues related to imports, you should consider setting `esModuleInterop` to `true` in your TypeScript configuration file (usually `tsconfig.json`). See https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#easier-ecmascript-module-interoperability for more information.
```

Author: mydea

jest/jest.config.js

@@ -3,8 +3,7 @@ module.exports = {
   rootDir: process.cwd(),
   collectCoverage: true,
   transform: {
-    '^.+\\.ts$': 'ts-jest',
-    '^.+\\.tsx$': 'ts-jest',
+    '^.+\\.(ts|tsx)$': 'ts-jest',
   },
   coverageDirectory: '<rootDir>/coverage',
   moduleFileExtensions: ['js', 'ts', 'tsx'],
@@ -15,6 +14,10 @@ module.exports = {
   globals: {
     'ts-jest': {
       tsconfig: '<rootDir>/tsconfig.test.json',
+      diagnostics: {
+        // Ignore this warning for tests, we do not care about this
+        ignoreCodes: ['TS151001'],
+      },
     },
     __DEBUG_BUILD__: true,
   },

packages/core/test/lib/envelope.test.ts

@@ -95,6 +95,13 @@ describe('createSpanEnvelope', () => {
     client = new TestClient(options);
     setCurrentClient(client);
     client.init();
+
+    // We want to avoid console errors in the tests
+    jest.spyOn(console, 'error').mockImplementation(() => {});
+  });
+
+  afterEach(() => {
+    jest.resetAllMocks();
   });
 
   it('creates a span envelope', () => {

packages/core/test/lib/metrics/browser-aggregator.test.ts

@@ -3,6 +3,10 @@ import { CounterMetric } from '../../../src/metrics/instance';
 import { serializeMetricBuckets } from '../../../src/metrics/utils';
 import { TestClient, getDefaultTestClientOptions } from '../../mocks/client';
 
+function _cleanupAggregator(aggregator: BrowserMetricsAggregator): void {
+  clearInterval(aggregator['_interval']);
+}
+
 describe('BrowserMetricsAggregator', () => {
   const options = getDefaultTestClientOptions({ tracesSampleRate: 0.0 });
   const testClient = new TestClient(options);
@@ -21,6 +25,8 @@ describe('BrowserMetricsAggregator', () => {
       timestamp: expect.any(Number),
       unit: 'none',
     });
+
+    _cleanupAggregator(aggregator);
   });
 
   it('groups same items together', () => {
@@ -40,6 +46,8 @@ describe('BrowserMetricsAggregator', () => {
       unit: 'none',
     });
     expect(firstValue.metric._value).toEqual(2);
+
+    _cleanupAggregator(aggregator);
   });
 
   it('differentiates based on tag value', () => {
@@ -48,6 +56,8 @@ describe('BrowserMetricsAggregator', () => {
     expect(aggregator['_buckets'].size).toEqual(1);
     aggregator.add('g', 'cpu', 55, undefined, { a: 'value' });
     expect(aggregator['_buckets'].size).toEqual(2);
+
+    _cleanupAggregator(aggregator);
   });
 
   describe('serializeBuckets', () => {
@@ -69,6 +79,8 @@ describe('BrowserMetricsAggregator', () => {
       expect(serializedBuckets).toContain('cpu@none:52:50:55:157:3|g|T');
       expect(serializedBuckets).toContain('lcp@second:1:1.2|d|#a:value,b:anothervalue|T');
       expect(serializedBuckets).toContain('important_people@none:97:98|s|#numericKey:2|T');
+
+      _cleanupAggregator(aggregator);
     });
   });
 });

packages/nextjs/test/utils/tunnelRoute.test.ts

@@ -34,6 +34,9 @@ describe('applyTunnelRouteOption()', () => {
   });
 
   it("Doesn't apply `tunnelRoute` when DSN is invalid", () => {
+    // Avoid polluting the test output with error messages
+    const mockConsoleError = jest.spyOn(console, 'error').mockImplementation(() => {});
+
     globalWithInjectedValues._sentryRewritesTunnelPath = '/my-error-monitoring-route';
     const options: any = {
       dsn: 'invalidDsn',
@@ -42,6 +45,8 @@ describe('applyTunnelRouteOption()', () => {
     applyTunnelRouteOption(options);
 
     expect(options.tunnel).toBeUndefined();
+
+    mockConsoleError.mockRestore();
   });
 
   it("Doesn't apply `tunnelRoute` option when `tunnelRoute` option wasn't injected", () => {