remove finish reason tag

Author: mydea

packages/core/src/tracing/idleSpan.ts

@@ -9,16 +9,14 @@ import { getSpanDescendants, removeChildSpanFromSpan, spanTimeInputToSeconds, sp
 import { SentryNonRecordingSpan } from './sentryNonRecordingSpan';
 import { SPAN_STATUS_ERROR } from './spanstatus';
 import { startInactiveSpan } from './trace';
-import { getActiveSpan, getCapturedScopesOnSpan } from './utils';
+import { getActiveSpan } from './utils';
 
 export const TRACING_DEFAULTS = {
   idleTimeout: 1_000,
   finalTimeout: 30_000,
   childSpanTimeout: 15_000,
 };
 
-const FINISH_REASON_TAG = 'finishReason';
-
 const FINISH_REASON_HEARTBEAT_FAILED = 'heartbeatFailed';
 const FINISH_REASON_IDLE_TIMEOUT = 'idleTimeout';
 const FINISH_REASON_FINAL_TIMEOUT = 'finalTimeout';
@@ -245,22 +243,6 @@ export function startIdleSpan(startSpanOptions: StartSpanOptions, options: Parti
       span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, _finishReason);
     }
 
-    // Save finish reason as tag, in addition to attribute, to maintain backwards compatibility
-    const scopes = getCapturedScopesOnSpan(span);
-
-    // Make sure to fetch up-to-date data here, as it may have been updated above
-    const finalAttributes: SpanAttributes = spanToJSON(span).data || {};
-    const finalFinishReason = finalAttributes[SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON];
-    if (scopes.scope && typeof finalFinishReason === 'string') {
-      // We only want to add the tag to the transaction event itself
-      scopes.scope.addEventProcessor(event => {
-        if (event.type === 'transaction') {
-          event.tags = { ...event.tags, [FINISH_REASON_TAG]: finalFinishReason };
-        }
-        return event;
-      });
-    }
-
     DEBUG_BUILD &&
       logger.log('[Tracing] finishing idle span', new Date(endTimestamp * 1000).toISOString(), spanJSON.op);
 

packages/core/test/lib/tracing/idleSpan.test.ts

@@ -296,7 +296,6 @@ describe('startIdleSpan', () => {
     expect(transaction?.contexts?.trace?.data?.[SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON]).toEqual(
       'idleTimeout',
     );
-    expect(transaction?.tags?.finishReason).toEqual('idleTimeout');
   });
 
   it('uses finish reason set outside when span ends', () => {
@@ -320,7 +319,6 @@ describe('startIdleSpan', () => {
     expect(transaction?.contexts?.trace?.data?.[SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON]).toEqual(
       'custom reason',
     );
-    expect(transaction?.tags?.finishReason).toEqual('custom reason');
   });
 
   describe('idleTimeout', () => {