ref: Remove deprecated properties from startSpan options (#11054)

So the public API for this is now fully aligned!

In nextjs, I moved places where we passed `request` as metadata to put
this on the isolation scope (in some places we already did that anyhow).

Author: mydea

dev-packages/e2e-tests/test-applications/nextjs-14/tests/generation-functions.test.ts

@@ -7,7 +7,7 @@ test('Should send a transaction event for a generateMetadata() function invokati
   const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
     return (
       transactionEvent?.transaction === 'Page.generateMetadata (/generation-functions)' &&
-      transactionEvent.contexts?.trace?.data?.['searchParams']?.['metadataTitle'] === testTitle
+      (transactionEvent.extra?.route_data as any)?.searchParams?.metadataTitle === testTitle
     );
   });
 
@@ -26,8 +26,8 @@ test('Should send a transaction and an error event for a faulty generateMetadata
 
   const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
     return (
-      transactionEvent?.transaction === 'Page.generateMetadata (/generation-functions)' &&
-      transactionEvent.contexts?.trace?.data?.['searchParams']?.['metadataTitle'] === testTitle
+      transactionEvent.transaction === 'Page.generateMetadata (/generation-functions)' &&
+      (transactionEvent.extra?.route_data as any)?.searchParams?.metadataTitle === testTitle
     );
   });
 
@@ -47,7 +47,7 @@ test('Should send a transaction event for a generateViewport() function invokati
   const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
     return (
       transactionEvent?.transaction === 'Page.generateViewport (/generation-functions)' &&
-      transactionEvent.contexts?.trace?.data?.['searchParams']?.['viewportThemeColor'] === testTitle
+      (transactionEvent.extra?.route_data as any)?.searchParams?.viewportThemeColor === testTitle
     );
   });
 
@@ -64,7 +64,7 @@ test('Should send a transaction and an error event for a faulty generateViewport
   const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
     return (
       transactionEvent?.transaction === 'Page.generateViewport (/generation-functions)' &&
-      transactionEvent.contexts?.trace?.data?.['searchParams']?.['viewportThemeColor'] === testTitle
+      (transactionEvent.extra?.route_data as any)?.searchParams?.viewportThemeColor === testTitle
     );
   });
 
@@ -86,7 +86,7 @@ test('Should send a transaction event with correct status for a generateMetadata
   const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
     return (
       transactionEvent?.transaction === 'Page.generateMetadata (/generation-functions/with-redirect)' &&
-      transactionEvent.contexts?.trace?.data?.['searchParams']?.['metadataTitle'] === testTitle
+      (transactionEvent.extra?.route_data as any)?.searchParams?.metadataTitle === testTitle
     );
   });
 
@@ -103,7 +103,7 @@ test('Should send a transaction event with correct status for a generateMetadata
   const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
     return (
       transactionEvent?.transaction === 'Page.generateMetadata (/generation-functions/with-notfound)' &&
-      transactionEvent.contexts?.trace?.data?.['searchParams']?.['metadataTitle'] === testTitle
+      (transactionEvent.extra?.route_data as any)?.searchParams?.metadataTitle === testTitle
     );
   });
 

dev-packages/e2e-tests/tracing-shim-esm/index.cjs

@@ -10,7 +10,6 @@ import {
   getMainCarrier,
   setAsyncContextStrategy,
   setCurrentClient,
-  spanIsSampled,
   spanToJSON,
   withScope,
 } from '../../../src';
@@ -101,33 +100,6 @@ describe('startSpan', () => {
       expect(spanToJSON(_span!).status).toEqual(isError ? 'internal_error' : undefined);
     });
 
-    it('allows traceparent information to be overriden', async () => {
-      let _span: Span | undefined = undefined;
-      client.on('spanEnd', span => {
-        _span = span;
-      });
-      try {
-        await startSpan(
-          {
-            name: 'GET users/[id]',
-            parentSampled: true,
-            traceId: '12345678901234567890123456789012',
-            parentSpanId: '1234567890123456',
-          },
-          () => {
-            return callback();
-          },
-        );
-      } catch (e) {
-        //
-      }
-      expect(_span).toBeDefined();
-
-      expect(spanIsSampled(_span!)).toEqual(true);
-      expect(spanToJSON(_span!).trace_id).toEqual('12345678901234567890123456789012');
-      expect(spanToJSON(_span!).parent_span_id).toEqual('1234567890123456');
-    });
-
     it('allows for transaction to be mutated', async () => {
       let _span: Span | undefined = undefined;
       client.on('spanEnd', span => {
@@ -153,7 +125,7 @@ describe('startSpan', () => {
         }
       });
       try {
-        await startSpan({ name: 'GET users/[id]', parentSampled: true }, () => {
+        await startSpan({ name: 'GET users/[id]' }, () => {
           return startSpan({ name: 'SELECT * from users' }, () => {
             return callback();
           });
@@ -179,7 +151,7 @@ describe('startSpan', () => {
         }
       });
       try {
-        await startSpan({ name: 'GET users/[id]', parentSampled: true }, () => {
+        await startSpan({ name: 'GET users/[id]' }, () => {
           return startSpan({ name: 'SELECT * from users' }, childSpan => {
             if (childSpan) {
               childSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_OP, 'db.query');
@@ -453,12 +425,9 @@ describe('startSpan', () => {
     setCurrentClient(client);
     client.init();
 
-    startSpan(
-      { name: 'outer', attributes: { test1: 'aa', test2: 'aa' }, data: { test1: 'bb', test3: 'bb' } },
-      outerSpan => {
-        expect(outerSpan).toBeDefined();
-      },
-    );
+    startSpan({ name: 'outer', attributes: { test1: 'aa', test2: 'aa', test3: 'bb' } }, outerSpan => {
+      expect(outerSpan).toBeDefined();
+    });
 
     expect(tracesSampler).toBeCalledTimes(1);
     expect(tracesSampler).toHaveBeenLastCalledWith({

dev-packages/e2e-tests/tracing-shim-esm/index.mjs

@@ -223,7 +223,7 @@ function _instrumentEmberRunloop(config: EmberSentryConfig): void {
             },
             name: 'runloop',
             op: `ui.ember.runloop.${queue}`,
-            startTimestamp: currentQueueStart,
+            startTime: currentQueueStart,
           })?.end(now);
         }
         currentQueueStart = undefined;
@@ -295,7 +295,7 @@ function processComponentRenderAfter(
     startInactiveSpan({
       name: payload.containerKey || payload.object,
       op,
-      startTimestamp: begin.now,
+      startTime: begin.now,
       attributes: {
         [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.ember',
       },
@@ -374,17 +374,17 @@ function _instrumentInitialLoad(config: EmberSentryConfig): void {
   // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
   const measure = measures[0]!;
 
-  const startTimestamp = (measure.startTime + browserPerformanceTimeOrigin) / 1000;
-  const endTimestamp = startTimestamp + measure.duration / 1000;
+  const startTime = (measure.startTime + browserPerformanceTimeOrigin) / 1000;
+  const endTime = startTime + measure.duration / 1000;
 
   startInactiveSpan({
     op: 'ui.ember.init',
     name: 'init',
     attributes: {
       [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.ember',
     },
-    startTimestamp,
-  })?.end(endTimestamp);
+    startTime,
+  })?.end(endTime);
   performance.clearMarks(startName);
   performance.clearMarks(endName);
 

dev-packages/e2e-tests/tracing-shim-esm/package.json

@@ -5,6 +5,7 @@ import {
   addTracingExtensions,
   captureException,
   continueTrace,
+  getIsolationScope,
   handleCallbackErrors,
   setHttpStatus,
   startSpan,
@@ -39,6 +40,9 @@ export function withEdgeWrapping<H extends EdgeRouteHandler>(
         baggage,
       },
       () => {
+        getIsolationScope().setSDKProcessingMetadata({
+          request: req instanceof Request ? winterCGRequestToRequestData(req) : undefined,
+        });
         return startSpan(
           {
             name: options.spanDescription,
@@ -47,9 +51,6 @@ export function withEdgeWrapping<H extends EdgeRouteHandler>(
               [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
               [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.nextjs.withEdgeWrapping',
             },
-            metadata: {
-              request: req instanceof Request ? winterCGRequestToRequestData(req) : undefined,
-            },
           },
           async span => {
             const handlerResult = await handleCallbackErrors(

dev-packages/e2e-tests/tracing-shim/index.js

@@ -91,9 +91,6 @@ export function wrapApiHandlerWithSentry(apiHandler: NextApiHandler, parameteriz
                   [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
                   [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.nextjs',
                 },
-                metadata: {
-                  request: req,
-                },
               },
               async span => {
                 // eslint-disable-next-line @typescript-eslint/unbound-method