don't do anything if already paused

Author: Lms24

packages/replay/src/replay.ts

@@ -275,6 +275,10 @@ export class ReplayContainer implements ReplayContainerInterface {
    * not as thorough of a shutdown as `stop()`.
    */
   public pause(): void {
+    console.log('I was called');
+
+    console.trace();
+
     this._isPaused = true;
     try {
       if (this._stopRecording) {
@@ -1093,6 +1097,12 @@ export class ReplayContainer implements ReplayContainerInterface {
    * Pauses the replay and resumes it after the rate-limit duration is over.
    */
   private _handleRateLimit(): void {
+    // in case recording is already paused, we don't need to do anything, as we might have already paused because of a
+    // rate limit
+    if (this.isPaused()) {
+      return;
+    }
+
     const rateLimitEnd = disabledUntil(this._rateLimits, 'replay');
     const rateLimitDuration = rateLimitEnd - Date.now();
 

packages/replay/test/integration/rateLimiting.test.ts

@@ -259,4 +259,38 @@ describe('Integration | rate-limiting behaviour', () => {
     // events array should be empty
     expect(replay.eventBuffer?.pendingLength).toBe(0);
   });
+
+  it("doesn't do anything, if a rate limit is hit and recording is already paused", async () => {
+    let paused = false;
+    expect(replay.session?.segmentId).toBe(0);
+    jest.spyOn(replay, 'isPaused').mockImplementation(() => {
+      return paused;
+    });
+    jest.spyOn(replay, 'pause');
+    jest.spyOn(replay, 'resume');
+    // @ts-ignore private API
+    jest.spyOn(replay, '_handleRateLimit');
+
+    const TEST_EVENT = { data: {}, timestamp: BASE_TIMESTAMP, type: 2 };
+
+    mockTransportSend.mockImplementationOnce(() => {
+      return Promise.resolve({ statusCode: 429 });
+    });
+
+    mockRecord._emitter(TEST_EVENT);
+    paused = true;
+
+    // T = base + 5
+    await advanceTimers(DEFAULT_FLUSH_MIN_DELAY);
+
+    expect(mockRecord.takeFullSnapshot).not.toHaveBeenCalled();
+    expect(mockTransportSend).toHaveBeenCalledTimes(1);
+
+    expect(replay).toHaveLastSentReplay({ events: JSON.stringify([TEST_EVENT]) });
+
+    expect(replay['_handleRateLimit']).toHaveBeenCalledTimes(1);
+    expect(replay.resume).not.toHaveBeenCalled();
+    expect(replay.isPaused).toHaveBeenCalledTimes(2);
+    expect(replay.pause).not.toHaveBeenCalled();
+  });
 });