Skip to content

Commit 3c7b107

Browse files
committed
build: Remove tslint danger
1 parent 8b38062 commit 3c7b107

File tree

7 files changed

+76
-1256
lines changed

7 files changed

+76
-1256
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# THIS IS A TEMPORARY FILE
22
# THIS WILL BE REMOVED AFTER WE FINISH ESLINT UPGRADE
33

4-
packages/node/**/*
54
packages/react/**/*
65
packages/tracing/**/*
76
packages/typescript/**/*

.eslintrc.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ module.exports = {
44
node: true,
55
},
66
extends: ['prettier', 'eslint:recommended', 'plugin:import/errors', 'plugin:import/warnings'],
7-
plugins: ['sentry-sdk', 'simple-import-sort'],
8-
ignorePatterns: ['eslint-plugin-sentry-sdk'],
7+
plugins: ['sentry-sdks', 'simple-import-sort'],
8+
ignorePatterns: ['eslint-plugin-sentry-sdks'],
99
overrides: [
1010
{
1111
// Configuration for JavaScript files

dangerfile.ts

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
import { exec } from 'child_process';
22
import { danger, fail, message, schedule, warn } from 'danger';
3-
import tslint from 'danger-plugin-tslint';
4-
import { prettyResults } from 'danger-plugin-tslint/dist/prettyResults';
53
import { CLIEngine } from 'eslint';
6-
import { resolve } from 'path';
74
import { promisify } from 'util';
85

9-
const PACKAGES = ['node'];
106
const EXTENSIONS = ['.js', '.jsx', '.ts', '.tsx'];
117

128
/**
@@ -48,35 +44,6 @@ export default async (): Promise<void> => {
4844
return;
4945
}
5046

51-
schedule(async () => {
52-
const tsLintResult = (
53-
await Promise.all(
54-
PACKAGES.map(packageName => {
55-
return new Promise<string>(res => {
56-
tslint({
57-
lintResultsJsonPath: resolve(__dirname, 'packages', packageName, 'lint-results.json'),
58-
handleResults: results => {
59-
if (results.length > 0) {
60-
const formattedResults = prettyResults(results);
61-
res(`TSLint failed: **@sentry/${packageName}**\n\n${formattedResults}`);
62-
} else {
63-
res('');
64-
}
65-
},
66-
});
67-
});
68-
}),
69-
)
70-
).filter(str => str.length);
71-
if (tsLintResult.length) {
72-
tsLintResult.forEach(tsLintFail => {
73-
fail(`${tsLintFail}`);
74-
});
75-
} else {
76-
message('✅ TSLint passed');
77-
}
78-
});
79-
8047
await eslint();
8148

8249
const hasChangelog = danger.git.modified_files.indexOf('CHANGELOG.md') !== -1;
File renamed without changes.

eslint-plugin-sentry-sdk/package.json renamed to eslint-plugin-sentry-sdks/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "eslint-plugin-sentry-sdk",
2+
"name": "eslint-plugin-sentry-sdks",
33
"version": "0.0.1",
44
"main": "index.js",
55
"devDependencies": {

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,12 @@
4949
"chai": "^4.1.2",
5050
"codecov": "^3.6.5",
5151
"danger": "^7.1.3",
52-
"danger-plugin-eslint": "^0.1.0",
53-
"danger-plugin-tslint": "^2.0.0",
5452
"eslint": "^7.5.0",
5553
"eslint-config-prettier": "^6.11.0",
5654
"eslint-plugin-deprecation": "^1.1.0",
5755
"eslint-plugin-import": "^2.22.0",
5856
"eslint-plugin-jsdoc": "^30.0.3",
59-
"eslint-plugin-sentry-sdk": "file:./eslint-plugin-sentry-sdk",
57+
"eslint-plugin-sentry-sdks": "file:./eslint-plugin-sentry-sdks",
6058
"eslint-plugin-simple-import-sort": "^5.0.3",
6159
"jest": "^24.7.1",
6260
"karma-browserstack-launcher": "^1.5.1",

0 commit comments

Comments
 (0)