Skip to content

Commit 3c462a8

Browse files
committed
define option types better
1 parent aecfb71 commit 3c462a8

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

packages/node/src/integrations/tracing/express.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,18 @@ type ExpressMiddleware = (
8383
next: (error: MiddlewareError) => void,
8484
) => void;
8585

86-
/**
87-
* An Express-compatible error handler.
88-
*/
89-
export function expressErrorHandler(options?: {
86+
interface ExpressHandlerOptions {
9087
/**
9188
* Callback method deciding whether error should be captured and sent to Sentry
9289
* @param error Captured middleware error
9390
*/
9491
shouldHandleError?(this: void, error: MiddlewareError): boolean;
95-
}): ExpressMiddleware {
92+
}
93+
94+
/**
95+
* An Express-compatible error handler.
96+
*/
97+
export function expressErrorHandler(options?: ExpressHandlerOptions): ExpressMiddleware {
9698
return function sentryErrorMiddleware(
9799
error: MiddlewareError,
98100
_req: http.IncomingMessage,
@@ -137,7 +139,7 @@ export function expressErrorHandler(options?: {
137139
*/
138140
export function setupExpressErrorHandler(
139141
app: { use: (middleware: ExpressMiddleware) => unknown },
140-
options?: Parameters<typeof expressErrorHandler>[0],
142+
options?: ExpressHandlerOptions,
141143
): void {
142144
app.use(expressErrorHandler(options));
143145
ensureIsWrapped(app.use, 'express');

0 commit comments

Comments
 (0)