test(loader): Update loader & test for window.onerror (#7838)

Author: mydea

.github/workflows/build.yml

@@ -583,6 +583,7 @@ jobs:
         bundle:
           - loader_base
           - loader_eager
+          - loader_debug
           - loader_tracing
           - loader_replay
           - loader_tracing_replay

packages/browser-integration-tests/fixtures/loader.js

@@ -1,7 +1,7 @@
 import { expect } from '@playwright/test';
 
 import { sentryTest } from '../../../../utils/fixtures';
-import { envelopeRequestParser,waitForErrorRequest } from '../../../../utils/helpers';
+import { envelopeRequestParser, waitForErrorRequest } from '../../../../utils/helpers';
 
 sentryTest('captureException works', async ({ getLocalTestUrl, page }) => {
   const req = waitForErrorRequest(page);

packages/browser-integration-tests/loader-suites/loader/noOnLoad/captureException/test.ts

@@ -0,0 +1,8 @@
+const oldOnError = window.onerror;
+
+window.onerror = function () {
+  console.log('custom error');
+  oldOnError && oldOnError.apply(this, arguments);
+};
+
+window.doSomethingWrong();

packages/browser-integration-tests/loader-suites/loader/noOnLoad/customOnErrorHandler/subject.js

@@ -0,0 +1,15 @@
+import { expect } from '@playwright/test';
+
+import { sentryTest } from '../../../../utils/fixtures';
+import { envelopeRequestParser, waitForErrorRequest } from '../../../../utils/helpers';
+
+sentryTest('error handler works with a recursive custom error handler', async ({ getLocalTestUrl, page }) => {
+  const req = waitForErrorRequest(page);
+
+  const url = await getLocalTestUrl({ testDir: __dirname });
+  await page.goto(url);
+
+  const eventData = envelopeRequestParser(await req);
+  expect(eventData.exception?.values?.length).toBe(1);
+  expect(eventData.exception?.values?.[0]?.value).toBe('window.doSomethingWrong is not a function');
+});

packages/browser-integration-tests/loader-suites/loader/noOnLoad/customOnErrorHandler/test.ts

@@ -1,7 +1,7 @@
 import { expect } from '@playwright/test';
 
 import { sentryTest } from '../../../../utils/fixtures';
-import { envelopeRequestParser,waitForErrorRequest } from '../../../../utils/helpers';
+import { envelopeRequestParser, waitForErrorRequest } from '../../../../utils/helpers';
 
 sentryTest('captureException works', async ({ getLocalTestUrl, page }) => {
   const req = waitForErrorRequest(page);

packages/browser-integration-tests/loader-suites/loader/onLoad/captureException/test.ts

@@ -39,6 +39,7 @@
     "test:loader:tracing": "PW_BUNDLE=loader_tracing yarn test:loader",
     "test:loader:replay": "PW_BUNDLE=loader_replay yarn test:loader",
     "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
+    "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
     "test:ci": "playwright test ./suites --browser='all' --reporter='line'",
     "test:update-snapshots": "yarn test --update-snapshots --browser='all' && yarn test --update-snapshots",
     "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts",

packages/browser-integration-tests/package.json

@@ -11,17 +11,22 @@ const LOADER_TEMPLATE = readFileSync(path.join(__dirname, '../fixtures/loader.js
 
 const LOADER_CONFIGS: Record<string, { bundle: string; options: Record<string, unknown>; lazy: boolean }> = {
   loader_base: {
-    bundle: 'browser/build/bundles/bundle.es5.js',
+    bundle: 'browser/build/bundles/bundle.es5.min.js',
     options: {},
     lazy: true,
   },
   loader_eager: {
-    bundle: 'browser/build/bundles/bundle.es5.js',
+    bundle: 'browser/build/bundles/bundle.es5.min.js',
     options: {},
     lazy: false,
   },
+  loader_debug: {
+    bundle: 'browser/build/bundles/bundle.es5.debug.min.js',
+    options: { debug: true },
+    lazy: true,
+  },
   loader_tracing: {
-    bundle: 'browser/build/bundles/bundle.tracing.es5.js',
+    bundle: 'browser/build/bundles/bundle.tracing.es5.min.js',
     options: { tracesSampleRate: 1 },
     lazy: false,
   },