address PR review

Author: AbhiPrasad

packages/hub/src/hub.ts

@@ -636,7 +636,7 @@ export function getHubFromCarrier(carrier: Carrier): Hub {
  */
 export function setHubOnCarrier(carrier: Carrier, hub: Hub): boolean {
   if (!carrier) return false;
-  const sentry = (carrier.__SENTRY__ = carrier.__SENTRY__ || {});
-  sentry.hub = hub;
+  const __SENTRY__ = (carrier.__SENTRY__ = carrier.__SENTRY__ || {});
+  __SENTRY__.hub = hub;
   return true;
 }

packages/utils/src/global.ts

@@ -46,14 +46,19 @@ export function getGlobalObject<T>(): T & SentryGlobal {
 }
 
 /**
- * Returns a global singleton contained on the global `__SENTRY__` object.
+ * Returns a global singleton contained in the global `__SENTRY__` object.
+ *
+ * If the singleton doesn't already exist in `__SENTRY__`, it will be created using the given factory
+ * function and added to the `__SENTRY__` object.
  *
  * @param name name of the global singleton on __SENTRY__
- * @param creator creation function
+ * @param creator creator Factory function to create the singleton if it doesn't already exist on `__SENTRY__`
+ * @param obj (Optional) The global object on which to look for `__SENTRY__`, if not `getGlobalObject`'s return value
  * @returns the singleton
  */
 export function getGlobalSingleton<T>(name: keyof SentryGlobal['__SENTRY__'], creator: () => T, obj?: unknown): T {
   const global = (obj || getGlobalObject()) as SentryGlobal;
-  const sentry = (global.__SENTRY__ = global.__SENTRY__ || {});
-  return sentry[name] || (sentry[name] = creator());
+  const __SENTRY__ = (global.__SENTRY__ = global.__SENTRY__ || {});
+  const singleton = __SENTRY__[name] || (__SENTRY__[name] = creator());
+  return singleton;
 }