Skip to content

Commit 3683461

Browse files
billyvgbillyvg
committed
skip firefox for these tests due to flakeyness
1 parent c367c83 commit 3683461

File tree

3 files changed

+115
-80
lines changed

3 files changed

+115
-80
lines changed

‎packages/integration-tests/suites/replay/privacyInput/test.ts‎

Lines changed: 89 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -13,83 +13,96 @@ function isInputMutation(snap: incrementalData): snap is inputData {
1313
return snap.source == IncrementalSource.Input;
1414
}
1515

16-
sentryTest('should mask input initial value and its changes', async ({ getLocalTestPath, page }) => {
17-
if (shouldSkipReplayTest()) {
18-
sentryTest.skip();
19-
}
20-
21-
const reqPromise0 = waitForReplayRequest(page, 0);
22-
const reqPromise1 = waitForReplayRequest(page, 1);
23-
const reqPromise2 = waitForReplayRequest(page, 2);
24-
const reqPromise3 = waitForReplayRequest(page, 3);
25-
26-
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
27-
return route.fulfill({
28-
status: 200,
29-
contentType: 'application/json',
30-
body: JSON.stringify({ id: 'test-id' }),
16+
sentryTest(
17+
'should mask input initial value and its changes',
18+
async ({ browserName, forceFlushReplay, getLocalTestPath, page }) => {
19+
// TODO(replay): This is flakey on firefox where we do not always get the latest mutation.
20+
if (shouldSkipReplayTest() || browserName === 'firefox') {
21+
sentryTest.skip();
22+
}
23+
24+
const reqPromise0 = waitForReplayRequest(page, 0);
25+
const reqPromise1 = waitForReplayRequest(page, 1);
26+
const reqPromise2 = waitForReplayRequest(page, 2);
27+
const reqPromise3 = waitForReplayRequest(page, 3);
28+
29+
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
30+
return route.fulfill({
31+
status: 200,
32+
contentType: 'application/json',
33+
body: JSON.stringify({ id: 'test-id' }),
34+
});
3135
});
32-
});
3336

34-
const url = await getLocalTestPath({ testDir: __dirname });
35-
36-
await page.goto(url);
37-
38-
await reqPromise0;
39-
40-
const text = 'this is test text';
41-
42-
await page.locator('#input').type(text);
43-
const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);
44-
const lastSnapshot = snapshots[snapshots.length - 1];
45-
expect(lastSnapshot.text).toBe(text);
46-
47-
await page.locator('#input-masked').type(text);
48-
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
49-
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
50-
expect(lastSnapshot2.text).toBe('*'.repeat(text.length));
51-
52-
await page.locator('#input-ignore').type(text);
53-
const snapshots3 = getIncrementalRecordingSnapshots(await reqPromise3).filter(isInputMutation);
54-
expect(snapshots3.length).toBe(0);
55-
});
56-
57-
sentryTest('should mask textarea initial value and its changes', async ({ getLocalTestPath, page }) => {
58-
if (shouldSkipReplayTest()) {
59-
sentryTest.skip();
60-
}
61-
62-
const reqPromise0 = waitForReplayRequest(page, 0);
63-
const reqPromise1 = waitForReplayRequest(page, 1);
64-
const reqPromise2 = waitForReplayRequest(page, 2);
65-
const reqPromise3 = waitForReplayRequest(page, 3);
66-
67-
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
68-
return route.fulfill({
69-
status: 200,
70-
contentType: 'application/json',
71-
body: JSON.stringify({ id: 'test-id' }),
37+
const url = await getLocalTestPath({ testDir: __dirname });
38+
39+
await page.goto(url);
40+
41+
await reqPromise0;
42+
43+
const text = 'this is test text';
44+
45+
await page.locator('#input').type(text);
46+
await forceFlushReplay();
47+
const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);
48+
const lastSnapshot = snapshots[snapshots.length - 1];
49+
expect(lastSnapshot.text).toBe(text);
50+
51+
await page.locator('#input-masked').type(text);
52+
await forceFlushReplay();
53+
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
54+
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
55+
expect(lastSnapshot2.text).toBe('*'.repeat(text.length));
56+
57+
await page.locator('#input-ignore').type(text);
58+
await forceFlushReplay();
59+
const snapshots3 = getIncrementalRecordingSnapshots(await reqPromise3).filter(isInputMutation);
60+
expect(snapshots3.length).toBe(0);
61+
},
62+
);
63+
64+
sentryTest(
65+
'should mask textarea initial value and its changes',
66+
async ({ browserName, forceFlushReplay, getLocalTestPath, page }) => {
67+
// TODO(replay): This is flakey on firefox where we do not always get the latest mutation.
68+
if (shouldSkipReplayTest() || browserName === 'firefox') {
69+
sentryTest.skip();
70+
}
71+
72+
const reqPromise0 = waitForReplayRequest(page, 0);
73+
const reqPromise1 = waitForReplayRequest(page, 1);
74+
const reqPromise2 = waitForReplayRequest(page, 2);
75+
const reqPromise3 = waitForReplayRequest(page, 3);
76+
77+
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
78+
return route.fulfill({
79+
status: 200,
80+
contentType: 'application/json',
81+
body: JSON.stringify({ id: 'test-id' }),
82+
});
7283
});
73-
});
74-
75-
const url = await getLocalTestPath({ testDir: __dirname });
76-
77-
await page.goto(url);
78-
79-
await reqPromise0;
80-
81-
const text = 'this is test text';
82-
await page.locator('#textarea').type(text);
83-
const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);
84-
const lastSnapshot = snapshots[snapshots.length - 1];
85-
expect(lastSnapshot.text).toBe(text);
86-
87-
await page.locator('#textarea-masked').type(text);
88-
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
89-
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
90-
expect(lastSnapshot2.text).toBe('*'.repeat(text.length));
9184

92-
await page.locator('#textarea-ignore').type(text);
93-
const snapshots3 = getIncrementalRecordingSnapshots(await reqPromise3).filter(isInputMutation);
94-
expect(snapshots3.length).toBe(0);
95-
});
85+
const url = await getLocalTestPath({ testDir: __dirname });
86+
87+
await page.goto(url);
88+
await reqPromise0;
89+
90+
const text = 'this is test text';
91+
await page.locator('#textarea').type(text);
92+
await forceFlushReplay();
93+
const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);
94+
const lastSnapshot = snapshots[snapshots.length - 1];
95+
expect(lastSnapshot.text).toBe(text);
96+
97+
await page.locator('#textarea-masked').type(text);
98+
await forceFlushReplay();
99+
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
100+
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
101+
expect(lastSnapshot2.text).toBe('*'.repeat(text.length));
102+
103+
await page.locator('#textarea-ignore').type(text);
104+
await forceFlushReplay();
105+
const snapshots3 = getIncrementalRecordingSnapshots(await reqPromise3).filter(isInputMutation);
106+
expect(snapshots3.length).toBe(0);
107+
},
108+
);

‎packages/integration-tests/suites/replay/privacyInputMaskAll/test.ts‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ function isInputMutation(snap: incrementalData): snap is inputData {
1515

1616
sentryTest(
1717
'should mask input initial value and its changes from `maskAllInputs` and allow unmasked selector',
18-
async ({ getLocalTestPath, page }) => {
19-
if (shouldSkipReplayTest()) {
18+
async ({ browserName, forceFlushReplay, getLocalTestPath, page }) => {
19+
// TODO(replay): This is flakey on firefox where we do not always get the latest mutation.
20+
if (shouldSkipReplayTest() || browserName === 'firefox') {
2021
sentryTest.skip();
2122
}
2223

@@ -41,11 +42,13 @@ sentryTest(
4142
const text = 'this is test text';
4243

4344
await page.locator('#input').type(text);
45+
await forceFlushReplay();
4446
const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);
4547
const lastSnapshot = snapshots[snapshots.length - 1];
4648
expect(lastSnapshot.text).toBe('*'.repeat(text.length));
4749

4850
await page.locator('#input-unmasked').type(text);
51+
await forceFlushReplay();
4952
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
5053
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
5154
expect(lastSnapshot2.text).toBe(text);
@@ -54,8 +57,9 @@ sentryTest(
5457

5558
sentryTest(
5659
'should mask textarea initial value and its changes from `maskAllInputs` and allow unmasked selector',
57-
async ({ getLocalTestPath, page }) => {
58-
if (shouldSkipReplayTest()) {
60+
async ({ browserName, forceFlushReplay, getLocalTestPath, page }) => {
61+
// TODO(replay): This is flakey on firefox where we do not always get the latest mutation.
62+
if (shouldSkipReplayTest() || browserName === 'firefox') {
5963
sentryTest.skip();
6064
}
6165

@@ -78,12 +82,15 @@ sentryTest(
7882
await reqPromise0;
7983

8084
const text = 'this is test text';
85+
8186
await page.locator('#textarea').type(text);
87+
await forceFlushReplay();
8288
const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);
8389
const lastSnapshot = snapshots[snapshots.length - 1];
8490
expect(lastSnapshot.text).toBe('*'.repeat(text.length));
8591

8692
await page.locator('#textarea-unmasked').type(text);
93+
await forceFlushReplay();
8794
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
8895
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
8996
expect(lastSnapshot2.text).toBe(text);

‎packages/integration-tests/utils/fixtures.ts‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export type TestFixtures = {
2525
_autoSnapshotSuffix: void;
2626
testDir: string;
2727
getLocalTestPath: (options: { testDir: string }) => Promise<string>;
28+
forceFlushReplay: () => Promise<string>;
2829
runInChromium: (fn: (...args: unknown[]) => unknown, args?: unknown[]) => unknown;
2930
runInFirefox: (fn: (...args: unknown[]) => unknown, args?: unknown[]) => unknown;
3031
runInWebkit: (fn: (...args: unknown[]) => unknown, args?: unknown[]) => unknown;
@@ -92,6 +93,20 @@ const sentryTest = base.extend<TestFixtures>({
9293
return fn(...args);
9394
});
9495
},
96+
97+
forceFlushReplay: ({ page }, use) => {
98+
return use(() =>
99+
page.evaluate(`
100+
Object.defineProperty(document, 'visibilityState', {
101+
configurable: true,
102+
get: function () {
103+
return 'hidden';
104+
},
105+
});
106+
document.dispatchEvent(new Event('visibilitychange'));
107+
`),
108+
);
109+
},
95110
});
96111

97112
export { sentryTest };

0 commit comments

Comments
 (0)