Skip to content

Commit 36800f5

Browse files
committed
more comments and thoughts
1 parent 5b74787 commit 36800f5

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

packages/tracing/src/integrations/browsertracing.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,21 @@ import {
1414

1515
/**
1616
* TODO: Figure out Tracing._resetActiveTransaction()
17+
* - No clue :/
18+
* - Maybe on finish, all transactions should remove themselves off the scope?
1719
* TODO: Figure out Tracing.finishIdleTransaction()
20+
* - Need beforeFinish() transaction hook here
21+
* TODO: Figure out both XHR and Fetch tracing
22+
* - This should be a integration that just runs automatically like the router
23+
* TODO: _setupErrorHandling
24+
* - This should be a integration that runs automatically
25+
* TODO: _setupBackgroundTabDetection
26+
* - This something that works automatically too
27+
* - This just cancels active pageload/navigation on scope
28+
* - Provide option to to extend to all transactions??
29+
* TODO: Tracing._addPerformanceEntries
30+
* - This is a beforeFinish() hook here
31+
* Thoughts:
1832
* - This might be that we monkeypatch it here?
1933
* - Ex. say _activeTransaction.finish = () => { finish() and something }
2034
* - BrowserTracing wants to hook onto idleTransaction lifecyle, do something before and after

0 commit comments

Comments
 (0)