ERROR_CHECKOUT_TIME --> BUFFER_CHECKOUT_TIME

Author: billyvg

packages/replay/src/constants.ts

@@ -24,7 +24,7 @@ export const DEFAULT_FLUSH_MIN_DELAY = 5_000;
 export const DEFAULT_FLUSH_MAX_DELAY = 5_500;
 
 /* How long to wait for error checkouts */
-export const ERROR_CHECKOUT_TIME = 60_000;
+export const BUFFER_CHECKOUT_TIME = 60_000;
 
 export const RETRY_BASE_INTERVAL = 5000;
 export const RETRY_MAX_COUNT = 3;

packages/replay/src/replay.ts

@@ -4,7 +4,7 @@ import { captureException, getCurrentHub } from '@sentry/core';
 import type { Breadcrumb, ReplayRecordingMode } from '@sentry/types';
 import { logger } from '@sentry/utils';
 
-import { ERROR_CHECKOUT_TIME, MAX_SESSION_LIFE, SESSION_IDLE_DURATION, WINDOW } from './constants';
+import { BUFFER_CHECKOUT_TIME, MAX_SESSION_LIFE, SESSION_IDLE_DURATION, WINDOW } from './constants';
 import { setupPerformanceObserver } from './coreHandlers/performanceObserver';
 import { createEventBuffer } from './eventBuffer';
 import { clearSession } from './session/clearSession';
@@ -152,7 +152,6 @@ export class ReplayContainer implements ReplayContainerInterface {
   }
 
   /**
-<<<<<<< HEAD
    * Get the experimental options.
    * THIS IS INTERNAL AND SUBJECT TO CHANGE!
    * @hidden
@@ -204,9 +203,6 @@ export class ReplayContainer implements ReplayContainerInterface {
   /**
    * Start a replay regardless of sampling rate. Calling this will always
    * create a new session. Will throw an error if replay is already in progress.
-=======
-   * Initializes the plugin.
->>>>>>> develop
    *
    * Creates or loads a session, attaches listeners to varying events (DOM,
    * _performanceObserver, Recording, Sentry SDK, etc)
@@ -275,7 +271,7 @@ export class ReplayContainer implements ReplayContainerInterface {
         // When running in error sampling mode, we need to overwrite `checkoutEveryNms`
         // Without this, it would record forever, until an error happens, which we don't want
         // instead, we'll always keep the last 60 seconds of replay before an error happened
-        ...(this.recordingMode === 'buffer' && { checkoutEveryNms: ERROR_CHECKOUT_TIME }),
+        ...(this.recordingMode === 'buffer' && { checkoutEveryNms: BUFFER_CHECKOUT_TIME }),
         emit: getHandleRecordingEmit(this),
         onMutation: this._onMutationHandler,
       });

packages/replay/test/integration/errorSampleRate.test.ts

@@ -2,7 +2,7 @@ import { captureException, getCurrentHub } from '@sentry/core';
 
 import {
   DEFAULT_FLUSH_MIN_DELAY,
-  ERROR_CHECKOUT_TIME,
+  BUFFER_CHECKOUT_TIME,
   MAX_SESSION_LIFE,
   REPLAY_SESSION_KEY,
   SESSION_IDLE_DURATION,
@@ -529,7 +529,7 @@ describe('Integration | errorSampleRate', () => {
   });
 
   it('has correct timestamps when error occurs much later than initial pageload/checkout', async () => {
-    const ELAPSED = ERROR_CHECKOUT_TIME;
+    const ELAPSED = BUFFER_CHECKOUT_TIME;
     const TEST_EVENT = { data: {}, timestamp: BASE_TIMESTAMP, type: 3 };
     mockRecord._emitter(TEST_EVENT);