add guards around report

AbhiPrasad · AbhiPrasad · commit 323b3437c92f · 2021-07-14T14:49:34.000-04:00
diff --git a/packages/tracing/src/browser/web-vitals/getCLS.ts b/packages/tracing/src/browser/web-vitals/getCLS.ts
@@ -67,7 +67,9 @@ export const getCLS = (onReport: ReportHandler, reportAllChanges?: boolean): voi
       if (sessionValue > metric.value) {
         metric.value = sessionValue;
         metric.entries = sessionEntries;
-        report();
+        if (report) {
+          report();
+        }
       }
     }
   };
diff --git a/packages/tracing/src/browser/web-vitals/getLCP.ts b/packages/tracing/src/browser/web-vitals/getLCP.ts
@@ -51,7 +51,9 @@ export const getLCP = (onReport: ReportHandler, reportAllChanges?: boolean): voi
       metric.entries.push(entry);
     }
 
-    report();
+    if (report) {
+      report();
+    }
   };
 
   const po = observe('largest-contentful-paint', entryHandler);

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,9 @@ export const getCLS = (onReport: ReportHandler, reportAllChanges?: boolean): voi`
`67`	`67`	`if (sessionValue > metric.value) {`
`68`	`68`	`metric.value = sessionValue;`
`69`	`69`	`metric.entries = sessionEntries;`
`70`		`- report();`
	`70`	`+ if (report) {`
	`71`	`+ report();`
	`72`	`+ }`
`71`	`73`	`}`
`72`	`74`	`}`
`73`	`75`	`};`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,9 @@ export const getLCP = (onReport: ReportHandler, reportAllChanges?: boolean): voi`
`51`	`51`	`metric.entries.push(entry);`
`52`	`52`	`}`
`53`	`53`
`54`		`- report();`
	`54`	`+ if (report) {`
	`55`	`+ report();`
	`56`	`+ }`
`55`	`57`	`};`
`56`	`58`
`57`	`59`	`const po = observe('largest-contentful-paint', entryHandler);`