Skip to content

Commit 2edb005

Browse files
committed
fix tests
1 parent 35338b2 commit 2edb005

File tree

3 files changed

+8
-3
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/trace-lifetime

3 files changed

+8
-3
lines changed

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/navigation/test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,10 +489,12 @@ sentryTest(
489489
await page.locator('[data-sentry-feedback] .btn--primary').click();
490490

491491
const feedbackEvent = await feedbackEventPromise;
492+
493+
expect(feedbackEvent.type).toEqual('feedback');
494+
492495
const feedbackTraceContext = feedbackEvent.contexts?.trace;
493496

494497
expect(feedbackTraceContext).toMatchObject({
495-
op: 'navigation',
496498
trace_id: navigationTraceContext?.trace_id,
497499
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
498500
});

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-meta/test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,9 @@ sentryTest('user feedback event after pageload has pageload traceId in headers',
459459
const feedbackEvent = await feedbackEventPromise;
460460
const feedbackTraceContext = feedbackEvent.contexts?.trace;
461461

462+
expect(feedbackEvent.type).toEqual('feedback');
463+
462464
expect(feedbackTraceContext).toMatchObject({
463-
op: 'pageload',
464465
trace_id: META_TAG_TRACE_ID,
465466
parent_span_id: META_TAG_PARENT_SPAN_ID,
466467
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),

dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,10 +459,12 @@ sentryTest('user feedback event after pageload has pageload traceId in headers',
459459
await page.locator('[data-sentry-feedback] .btn--primary').click();
460460

461461
const feedbackEvent = await feedbackEventPromise;
462+
463+
expect(feedbackEvent.type).toEqual('feedback');
464+
462465
const feedbackTraceContext = feedbackEvent.contexts?.trace;
463466

464467
expect(feedbackTraceContext).toMatchObject({
465-
op: 'pageload',
466468
trace_id: pageloadTraceContext?.trace_id,
467469
span_id: expect.stringMatching(/^[0-9a-f]{16}$/),
468470
});

0 commit comments

Comments
 (0)