build: Add @typescript-eslint/consistent-type-imports rule (#6662)

This ensures we use a `type` import when we only need type stuff.

Author: mydea

packages/angular/src/errorhandler.ts

@@ -1,5 +1,6 @@
 import { HttpErrorResponse } from '@angular/common/http';
-import { ErrorHandler as AngularErrorHandler, Inject, Injectable } from '@angular/core';
+import type { ErrorHandler as AngularErrorHandler } from '@angular/core';
+import { Inject, Injectable } from '@angular/core';
 import * as Sentry from '@sentry/browser';
 import { captureException } from '@sentry/browser';
 import { addExceptionMechanism, isString } from '@sentry/utils';

packages/angular/src/sdk.ts

@@ -1,5 +1,6 @@
 import { VERSION } from '@angular/core';
-import { BrowserOptions, init as browserInit, SDK_VERSION, setContext } from '@sentry/browser';
+import type { BrowserOptions } from '@sentry/browser';
+import { init as browserInit, SDK_VERSION, setContext } from '@sentry/browser';
 import { logger } from '@sentry/utils';
 
 import { ANGULAR_MINIMUM_VERSION } from './constants';

packages/angular/src/tracing.ts

@@ -1,10 +1,13 @@
 /* eslint-disable max-lines */
-import { AfterViewInit, Directive, Injectable, Input, NgModule, OnDestroy, OnInit } from '@angular/core';
-import { ActivatedRouteSnapshot, Event, NavigationEnd, NavigationStart, ResolveEnd, Router } from '@angular/router';
+import type { AfterViewInit, OnDestroy, OnInit } from '@angular/core';
+import { Directive, Injectable, Input, NgModule } from '@angular/core';
+import type { ActivatedRouteSnapshot, Event, Router } from '@angular/router';
+import { NavigationEnd, NavigationStart, ResolveEnd } from '@angular/router';
 import { getCurrentHub, WINDOW } from '@sentry/browser';
-import { Span, Transaction, TransactionContext } from '@sentry/types';
+import type { Span, Transaction, TransactionContext } from '@sentry/types';
 import { logger, stripUrlQueryAndFragment, timestampWithMs } from '@sentry/utils';
-import { Observable, Subscription } from 'rxjs';
+import type { Observable } from 'rxjs';
+import { Subscription } from 'rxjs';
 import { filter, tap } from 'rxjs/operators';
 
 import { ANGULAR_INIT_OP, ANGULAR_OP, ANGULAR_ROUTING_OP } from './constants';

packages/angular/test/tracing.test.ts

@@ -1,6 +1,6 @@
 import { Component } from '@angular/core';
-import { ActivatedRouteSnapshot } from '@angular/router';
-import { Hub } from '@sentry/types';
+import type { ActivatedRouteSnapshot } from '@angular/router';
+import type { Hub } from '@sentry/types';
 
 import { instrumentAngularRouting, TraceClassDecorator, TraceDirective, TraceMethodDecorator } from '../src';
 import { getParameterizedRouteFromSnapshot } from '../src/tracing';

packages/angular/test/utils/index.ts

@@ -1,8 +1,10 @@
 import { Component, NgModule } from '@angular/core';
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { Router, Routes } from '@angular/router';
+import type { ComponentFixture } from '@angular/core/testing';
+import { TestBed } from '@angular/core/testing';
+import type { Routes } from '@angular/router';
+import { Router } from '@angular/router';
 import { RouterTestingModule } from '@angular/router/testing';
-import { Transaction } from '@sentry/types';
+import type { Transaction } from '@sentry/types';
 
 import { instrumentAngularRouting, TraceService } from '../../src';
 

packages/browser/src/client.ts

@@ -1,13 +1,21 @@
-import { BaseClient, getEnvelopeEndpointWithUrlEncodedAuth, Scope, SDK_VERSION } from '@sentry/core';
-import type { BrowserClientReplayOptions } from '@sentry/types';
-import { ClientOptions, Event, EventHint, Options, Severity, SeverityLevel } from '@sentry/types';
+import type { Scope } from '@sentry/core';
+import { BaseClient, getEnvelopeEndpointWithUrlEncodedAuth, SDK_VERSION } from '@sentry/core';
+import type {
+  BrowserClientReplayOptions,
+  ClientOptions,
+  Event,
+  EventHint,
+  Options,
+  Severity,
+  SeverityLevel,
+} from '@sentry/types';
 import { createClientReportEnvelope, dsnToString, logger, serializeEnvelope } from '@sentry/utils';
 
 import { eventFromException, eventFromMessage } from './eventbuilder';
 import { WINDOW } from './helpers';
-import { Breadcrumbs } from './integrations';
+import type { Breadcrumbs } from './integrations';
 import { BREADCRUMB_INTEGRATION_ID } from './integrations/breadcrumbs';
-import { BrowserTransportOptions } from './transports/types';
+import type { BrowserTransportOptions } from './transports/types';
 /**
  * Configuration options for the Sentry Browser SDK.
  * @see @sentry/types Options for more information.

packages/browser/src/eventbuilder.ts

@@ -1,5 +1,5 @@
 import { getCurrentHub } from '@sentry/core';
-import { Event, EventHint, Exception, Severity, SeverityLevel, StackFrame, StackParser } from '@sentry/types';
+import type { Event, EventHint, Exception, Severity, SeverityLevel, StackFrame, StackParser } from '@sentry/types';
 import {
   addExceptionMechanism,
   addExceptionTypeValue,

packages/browser/src/helpers.ts

@@ -1,5 +1,5 @@
 import { captureException, withScope } from '@sentry/core';
-import { DsnLike, Event as SentryEvent, Mechanism, Scope, WrappedFunction } from '@sentry/types';
+import type { DsnLike, Event as SentryEvent, Mechanism, Scope, WrappedFunction } from '@sentry/types';
 import {
   addExceptionMechanism,
   addExceptionTypeValue,

packages/browser/src/integrations/breadcrumbs.ts

@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable max-lines */
 import { getCurrentHub } from '@sentry/core';
-import { Event, Integration } from '@sentry/types';
+import type { Event, Integration } from '@sentry/types';
 import {
   addInstrumentationHandler,
   getEventDescription,

packages/browser/src/integrations/dedupe.ts

@@ -1,4 +1,4 @@
-import { Event, EventProcessor, Exception, Hub, Integration, StackFrame } from '@sentry/types';
+import type { Event, EventProcessor, Exception, Hub, Integration, StackFrame } from '@sentry/types';
 import { logger } from '@sentry/utils';
 
 /** Deduplication filter */