add tests

sorry

Author: Lms24

packages/sveltekit/src/client/load.ts

@@ -1,7 +1,7 @@
 import type { BaseClient } from '@sentry/core';
 import { getCurrentHub, trace } from '@sentry/core';
 import type { Breadcrumbs, BrowserTracing } from '@sentry/svelte';
-import { captureException, WINDOW } from '@sentry/svelte';
+import { captureException } from '@sentry/svelte';
 import type { ClientOptions, SanitizedRequestData } from '@sentry/types';
 import {
   addExceptionMechanism,
@@ -10,6 +10,7 @@ import {
   getFetchUrl,
   getSanitizedUrlString,
   objectify,
+  parseUrl,
   stringMatchesSomePattern,
 } from '@sentry/utils';
 import type { LoadEvent } from '@sveltejs/kit';
@@ -108,12 +109,12 @@ function instrumentSvelteKitFetch(originalFetch: SvelteKitFetch): SvelteKitFetch
 
   const browserTracingIntegration =
     client.getIntegrationById && (client.getIntegrationById('BrowserTracing') as BrowserTracing | undefined);
-  const breadcrumbsIntegration = client.getIntegrationById('BreadCrumbs') as Breadcrumbs | undefined;
+  const breadcrumbsIntegration = client.getIntegrationById('Breadcrumbs') as Breadcrumbs | undefined;
 
   const browserTracingOptions = browserTracingIntegration && browserTracingIntegration.options;
 
   const shouldTraceFetch = browserTracingOptions && browserTracingOptions.traceFetch;
-  const shouldAddFetchBreadcrumbs = breadcrumbsIntegration && breadcrumbsIntegration.options.fetch;
+  const shouldAddFetchBreadcrumb = breadcrumbsIntegration && breadcrumbsIntegration.options.fetch;
 
   /* Identical check as in BrowserTracing, just that we also need to verify that BrowserTracing is actually installed */
   const shouldCreateSpan =
@@ -132,9 +133,10 @@ function instrumentSvelteKitFetch(originalFetch: SvelteKitFetch): SvelteKitFetch
   return new Proxy(originalFetch, {
     apply: (wrappingTarget, thisArg, args: Parameters<LoadEvent['fetch']>) => {
       const [input, init] = args;
+
       const rawUrl = getFetchUrl(args);
 
-      const urlObject = new URL(rawUrl, WINDOW.document.baseURI);
+      const urlObject = parseUrl(rawUrl);
 
       const requestData: SanitizedRequestData = {
         url: getSanitizedUrlString(urlObject),
@@ -159,6 +161,7 @@ function instrumentSvelteKitFetch(originalFetch: SvelteKitFetch): SvelteKitFetch
       // only attach headers if we should create a span
       if (attachHeaders && createSpan) {
         const dsc = activeTransaction.getDynamicSamplingContext();
+
         const headers = addTracingHeadersToFetchRequest(
           input as string | Request,
           dsc,
@@ -176,6 +179,8 @@ function instrumentSvelteKitFetch(originalFetch: SvelteKitFetch): SvelteKitFetch
 
       let fetchPromise: Promise<Response>;
 
+      const patchedFetchArgs = [input, patchedInit];
+
       if (createSpan) {
         fetchPromise = trace(
           {
@@ -184,18 +189,18 @@ function instrumentSvelteKitFetch(originalFetch: SvelteKitFetch): SvelteKitFetch
             data: requestData,
           },
           span => {
-            const promise: Promise<Response> = wrappingTarget.apply(thisArg, [input, patchedInit]);
+            const promise: Promise<Response> = wrappingTarget.apply(thisArg, patchedFetchArgs);
             if (span) {
               promise.then(res => span.setHttpStatus(res.status)).catch(_ => span.setStatus('internal_error'));
             }
             return promise;
           },
         );
       } else {
-        fetchPromise = wrappingTarget.apply(thisArg, [input, patchedInit]);
+        fetchPromise = wrappingTarget.apply(thisArg, patchedFetchArgs);
       }
 
-      if (shouldAddFetchBreadcrumbs) {
+      if (shouldAddFetchBreadcrumb) {
         addFetchBreadcrumb(fetchPromise, requestData, args);
       }