Address review suggestions.

Author: onurtemizkan

packages/integration-tests/package.json

@@ -1,5 +1,5 @@
 {
-  "name": "sentry-browser-integration-tests",
+  "name": "browser-integration-tests",
   "version": "1.0.0",
   "main": "index.js",
   "license": "MIT",
@@ -19,7 +19,6 @@
   },
   "dependencies": {
     "@playwright/test": "^1.17.0",
-    "@sentry/browser": "file:../browser",
     "babel-loader": "^8.2.2",
     "handlebars-loader": "^1.7.1",
     "html-webpack-plugin": "^5.5.0",

packages/integration-tests/utils/fixtures.ts

@@ -5,11 +5,12 @@ import path from 'path';
 import { generatePage } from './generatePage';
 
 const getAsset = (assetDir: string, asset: string): string => {
-  const path = `${assetDir}/${asset}`;
-  if (fs.existsSync(path)) {
-    return path;
+  const assetPath = `${assetDir}/${asset}`;
+
+  if (fs.existsSync(assetPath)) {
+    return assetPath;
   }
-  
+
   return `${path.dirname(assetDir)}/${asset}`;
 };
 

packages/integration-tests/utils/generatePage.ts

@@ -21,7 +21,7 @@ async function generateSentryAlias(): Promise<Record<string, string>> {
     await Promise.all(
       dirents.map(async d => {
         const packageJSON: Package = JSON.parse(
-          await promises.readFile(path.resolve(PACKAGE_PATH, d, 'package.json'), { encoding: 'utf-8' }),
+          (await promises.readFile(path.resolve(PACKAGE_PATH, d, 'package.json'), { encoding: 'utf-8' })).toString(),
         );
         return [packageJSON['name'], path.resolve(PACKAGE_PATH, d)];
       }),
@@ -30,15 +30,12 @@ async function generateSentryAlias(): Promise<Record<string, string>> {
 }
 
 export async function generatePage(
-  initialization: string,
-  subject: string,
-  template: string,
+  initializationPath: string,
+  subjectPath: string,
+  templatePath: string,
   outPath: string,
 ): Promise<void> {
   const localPath = `${outPath}/dist`;
-  const initializationPath = `${initialization}`;
-  const subjectPath = `${subject}`;
-  const templatePath = `${template}`;
   const bundlePath = `${localPath}/index.html`;
 
   const alias = await generateSentryAlias();

yarn.lock

@@ -3031,14 +3031,6 @@
   resolved "https://registry.yarnpkg.com/@protobufjs/utf8/-/utf8-1.1.0.tgz#a777360b5b39a1a2e5106f8e858f2fd2d060c570"
   integrity sha1-p3c2C1s5oaLlEG+OhY8v0tBgxXA=
 
-"@sentry/browser@file:packages/browser":
-  version "6.16.0"
-  dependencies:
-    "@sentry/core" "6.16.0"
-    "@sentry/types" "6.16.0"
-    "@sentry/utils" "6.16.0"
-    tslib "^1.9.3"
-
 "@sentry/cli@^1.70.1":
   version "1.70.1"
   resolved "https://registry.yarnpkg.com/@sentry/cli/-/cli-1.70.1.tgz#908517b699c0714eff88bedb68c6ea72e94945e8"
@@ -20868,11 +20860,6 @@ typescript@^3.9.5, typescript@^3.9.7:
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.9.tgz#e69905c54bc0681d0518bd4d587cc6f2d0b1a674"
   integrity sha512-kdMjTiekY+z/ubJCATUPlRDl39vXYiMV9iyeMuEuXZh2we6zz80uovNN2WlAxmmdE/Z/YQe+EbOEXB5RHEED3w==
 
-typescript@^4.5.2:
-  version "4.5.2"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.5.2.tgz#8ac1fba9f52256fdb06fb89e4122fa6a346c2998"
-  integrity sha512-5BlMof9H1yGt0P8/WF+wPNw6GfctgGjXp5hkblpyT+8rkASSmkUKMXrxR0Xg8ThVCi/JnHQiKXeBaEwCeQwMFw==
-
 ua-parser-js@^0.7.18:
   version "0.7.26"
   resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-0.7.26.tgz#b3731860e241419abd5b542b1a0881070d92e0ce"