smol cleanup

Author: chargome

dev-packages/e2e-tests/lib/getTestMatrix.ts

@@ -146,34 +146,14 @@ function getAffectedTestApplications(
   // If something in e2e tests themselves are changed, check if only test applications were changed
   if (affectedProjects.includes('@sentry-internal/e2e-tests')) {
     try {
-      const changedFiles = execSync(
-        `git diff --name-only ${base}${head ? `..${head}` : ''} -- dev-packages/e2e-tests/`,
-        { encoding: 'utf-8' },
-      )
-        .toString()
-        .split('\n')
-        .map(line => line.trim())
-        .filter(Boolean);
-
-      // Check if only test application files were changed
-      const changedTestApps = new Set<string>();
-      const hasSharedCodeChanges = changedFiles.some(file => {
-        // Check if the file is within a test application directory
-        const testAppMatch = file.match(/^dev-packages\/e2e-tests\/test-applications\/([^/]+)\//);
-        if (testAppMatch?.[1]) {
-          changedTestApps.add(testAppMatch[1]);
-          return false;
-        }
-        // If it's not in test-applications/, we assume it's shared code
-        return true;
-      });
+      const changedTestApps = getChangedTestApps(base, head);
 
       // Shared code was changed, run all tests
-      if (hasSharedCodeChanges) {
+      if (changedTestApps === false) {
         return testApplications;
       }
 
-      // Only test applications were changed, run selectively
+      // Only test applications that were changed, run selectively
       if (changedTestApps.size > 0) {
         return testApplications.filter(testApp => changedTestApps.has(testApp));
       }
@@ -192,3 +172,32 @@ function getAffectedTestApplications(
     return sentryDependencies.some(dep => affectedProjects.includes(dep));
   });
 }
+
+function getChangedTestApps(base: string, head?: string): false | Set<string> {
+  const changedFiles = execSync(`git diff --name-only ${base}${head ? `..${head}` : ''} -- dev-packages/e2e-tests/`, {
+    encoding: 'utf-8',
+  })
+    .toString()
+    .split('\n')
+    .map(line => line.trim())
+    .filter(Boolean);
+
+  const changedTestApps: Set<string> = new Set();
+  const testAppsPrefix = 'dev-packages/e2e-tests/test-applications/';
+
+  for (const file of changedFiles) {
+    if (!file.startsWith(testAppsPrefix)) {
+      // Shared code change - need to run all tests
+      return false;
+    }
+
+    const pathAfterPrefix = file.slice(testAppsPrefix.length);
+    const slashIndex = pathAfterPrefix.indexOf('/');
+
+    if (slashIndex > 0) {
+      changedTestApps.add(pathAfterPrefix.slice(0, slashIndex));
+    }
+  }
+
+  return changedTestApps;
+}