fix(opentelemetry): Do not overwrite http span name if kind is internal

Author: mydea

packages/opentelemetry/src/utils/parseSpanDescription.ts

@@ -163,10 +163,14 @@ export function descriptionForHttpMethod(
     data['http.fragment'] = fragment;
   }
 
+  // If the span kind is neither client nor server, we use the original name
+  // this infers that somebody manually started this span, in which case we don't want to overwrite the name
+  const isClientOrServerKind = kind === SpanKind.CLIENT || kind === SpanKind.SERVER;
+
   return {
     op: opParts.join('.'),
-    description,
-    source,
+    description: isClientOrServerKind ? description : name,
+    source: isClientOrServerKind ? source : 'custom',
     data,
   };
 }

packages/opentelemetry/test/utils/parseSpanDescription.test.ts

@@ -231,6 +231,25 @@ describe('descriptionForHttpMethod', () => {
         source: 'route',
       },
     ],
+    [
+      'works with basic client GET with SpanKind.INTERNAL',
+      'GET',
+      {
+        [SEMATTRS_HTTP_METHOD]: 'GET',
+        [SEMATTRS_HTTP_URL]: 'https://www.example.com/my-path',
+        [SEMATTRS_HTTP_TARGET]: '/my-path',
+      },
+      'test name',
+      SpanKind.INTERNAL,
+      {
+        op: 'http',
+        description: 'test name',
+        data: {
+          url: 'https://www.example.com/my-path',
+        },
+        source: 'custom',
+      },
+    ],
   ])('%s', (_, httpMethod, attributes, name, kind, expected) => {
     const actual = descriptionForHttpMethod({ attributes, kind, name }, httpMethod);
     expect(actual).toEqual(expected);