add browser-specific source updates after calling updateName

Author: Lms24

packages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts

@@ -61,6 +61,7 @@ export function appRouterInstrumentNavigation(client: Client): void {
   WINDOW.addEventListener('popstate', () => {
     if (currentNavigationSpan && currentNavigationSpan.isRecording()) {
       currentNavigationSpan.updateName(WINDOW.location.pathname);
+      currentNavigationSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'url');
     } else {
       currentNavigationSpan = startBrowserTracingNavigationSpan(client, {
         name: WINDOW.location.pathname,
@@ -105,9 +106,11 @@ export function appRouterInstrumentNavigation(client: Client): void {
 
               if (routerFunctionName === 'push') {
                 span?.updateName(transactionNameifyRouterArgument(argArray[0]));
+                span?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'url');
                 span?.setAttribute('navigation.type', 'router.push');
               } else if (routerFunctionName === 'replace') {
                 span?.updateName(transactionNameifyRouterArgument(argArray[0]));
+                span?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'url');
                 span?.setAttribute('navigation.type', 'router.replace');
               } else if (routerFunctionName === 'back') {
                 span?.setAttribute('navigation.type', 'router.back');

packages/solid/src/solidrouter.ts

@@ -82,13 +82,14 @@ function withSentryRouterRoot(Root: Component<RouteSectionProps>): Component<Rou
       const rootSpan = getActiveRootSpan();
 
       if (rootSpan) {
-        const { op, description } = spanToJSON(rootSpan);
+        const { op, description, data } = spanToJSON(rootSpan);
 
         // We only need to update navigation spans that have been created by
         // a browser back-button navigation (stored as `-1` by solid router)
         // everything else was already instrumented correctly in `useBeforeLeave`
         if (op === 'navigation' && description === '-1') {
           rootSpan.updateName(name);
+          rootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, data && data[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]);
         }
       }
     });