remove noop transport

Author: AbhiPrasad

packages/browser/src/client.ts

@@ -124,7 +124,7 @@ export class BrowserClient extends BaseClient<BrowserOptions> {
   protected _setupTransport(): Transport {
     if (!this._options.dsn) {
       // We return the noop transport here in case there is no Dsn.
-      return super._setupTransport();
+      return undefined;
     }
 
     const transportOptions = {

packages/core/src/baseclient.ts

@@ -28,7 +28,6 @@ import {
 } from '@sentry/utils';
 
 import { IntegrationIndex, setupIntegrations } from './integration';
-import { NoopTransport } from './transports/noop';
 
 const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
 
@@ -76,7 +75,7 @@ export abstract class BaseClient<O extends Options> implements Client<O> {
   protected _numProcessing: number = 0;
 
   /** Cached transport used internally. */
-  protected _transport: Transport;
+  protected _transport: Transport | undefined;
 
   /**
    * Initializes this client instance.
@@ -194,7 +193,7 @@ export abstract class BaseClient<O extends Options> implements Client<O> {
   /**
    * @inheritDoc
    */
-  public getTransport(): Transport {
+  public getTransport(): Transport | undefined {
     return this._transport;
   }
 
@@ -203,9 +202,11 @@ export abstract class BaseClient<O extends Options> implements Client<O> {
    */
   public flush(timeout?: number): PromiseLike<boolean> {
     return this._isClientDoneProcessing(timeout).then(clientFinished => {
-      return this.getTransport()
-        .close(timeout)
-        .then(transportFlushed => clientFinished && transportFlushed);
+      const transport = this.getTransport();
+      if (transport) {
+        return transport.close(timeout).then(transportFlushed => clientFinished && transportFlushed);
+      }
+      return false;
     });
   }
 
@@ -244,21 +245,28 @@ export abstract class BaseClient<O extends Options> implements Client<O> {
    * @inheritDoc
    */
   public sendEvent(event: Event): void {
-    void this._transport.sendEvent(event).then(null, reason => {
-      logger.error(`Error while sending event: ${reason}`);
-    });
+    const transport = this.getTransport();
+    if (transport) {
+      void transport.sendEvent(event).then(null, reason => {
+        logger.error(`Error while sending event: ${reason}`);
+      });
+    }
   }
 
   /**
    * @inheritDoc
    */
   public sendSession(session: Session): void {
-    if (!this._transport.sendSession) {
+    const transport = this.getTransport();
+    if (!transport) {
+      return;
+    }
+    if (!transport.sendSession) {
       logger.warn("Dropping session because custom transport doesn't implement sendSession");
       return;
     }
 
-    void this._transport.sendSession(session).then(null, reason => {
+    void transport.sendSession(session).then(null, reason => {
       logger.error(`Error while sending session: ${reason}`);
     });
   }
@@ -525,7 +533,7 @@ export abstract class BaseClient<O extends Options> implements Client<O> {
     type RecordLostEventParams = Parameters<RecordLostEvent>;
 
     function recordLostEvent(outcome: RecordLostEventParams[0], category: RecordLostEventParams[1]): void {
-      if (transport.recordLostEvent) {
+      if (transport && transport.recordLostEvent) {
         transport.recordLostEvent(outcome, category);
       }
     }
@@ -613,8 +621,8 @@ export abstract class BaseClient<O extends Options> implements Client<O> {
   /**
    * Sets up the transport so it can be used later to send requests.
    */
-  protected _setupTransport(): Transport {
-    return new NoopTransport();
+  protected _setupTransport(): Transport | undefined {
+    return undefined;
   }
 
   /**

packages/core/src/transports/noop.ts

@@ -1,9 +1,28 @@
-import { Options, EventHint, Event, Session, SeverityLevel, Transport } from '@sentry/types';
+import { Options, EventHint, Event, Session, SeverityLevel, Transport, Response } from '@sentry/types';
 
 import { BaseClient } from '../../src/baseclient';
 import { initAndBind } from '../../src/sdk';
 import { resolvedSyncPromise } from '@sentry/utils';
 
+export class NoopTransport implements Transport {
+  /**
+   * @inheritDoc
+   */
+  public sendEvent(_: Event): PromiseLike<Response> {
+    return resolvedSyncPromise({
+      reason: `NoopTransport: Event has been skipped because no Dsn is configured.`,
+      status: 'skipped',
+    });
+  }
+
+  /**
+   * @inheritDoc
+   */
+  public close(_?: number): PromiseLike<boolean> {
+    return resolvedSyncPromise(true);
+  }
+}
+
 interface TestOptions extends Options {
   test?: boolean;
   mockInstallFailure?: boolean;
@@ -39,7 +58,7 @@ export class TestClient extends BaseClient<TestOptions> {
   protected _setupTransport(): Transport {
     if (!this._options.dsn) {
       // We return the noop transport here in case there is no Dsn.
-      return super._setupTransport();
+      return new NoopTransport();
     }
 
     const transportOptions = this._options.transportOptions
@@ -50,7 +69,7 @@ export class TestClient extends BaseClient<TestOptions> {
       return new this._options.transport(transportOptions);
     }
 
-    return super._setupTransport();
+    return new NoopTransport();
   }
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types

packages/core/test/mocks/client.ts

@@ -96,14 +96,21 @@ export class NodeClient extends BaseClient<NodeOptions> {
   /** Method that initialises an instance of SessionFlusher on Client */
   public initSessionFlusher(): void {
     const { release, environment } = this._options;
+    const transport = this.getTransport();
+
+    if (!transport) {
+      logger.warn('Cannot initialise an instance of SessionFlusher if no transport is initialized!');
+      return;
+    }
     if (!release) {
       logger.warn('Cannot initialise an instance of SessionFlusher if no release is provided!');
-    } else {
-      this._sessionFlusher = new SessionFlusher(this.getTransport(), {
-        release,
-        environment,
-      });
+      return;
     }
+
+    this._sessionFlusher = new SessionFlusher(transport, {
+      release,
+      environment,
+    });
   }
 
   /**

packages/node/src/client.ts

@@ -61,7 +61,7 @@ export interface Client<O extends Options = Options> {
   getOptions(): O;
 
   /** Returns clients transport. */
-  getTransport?(): Transport;
+  getTransport?(): Transport | undefined;
 
   /**
    * Flush the event queue and set the client to `enabled = false`. See {@link Client.flush}.