cleanup

Author: mydea

packages/integration-tests/suites/replay/errors/errorMode/test.ts

@@ -53,6 +53,8 @@ for (let i = 0; i < 100; i++) {
 
       await page.goto(url);
       await page.click('#go-background');
+      await new Promise(resolve => setTimeout(resolve, 1000));
+
       expect(callsToSentry).toEqual(0);
 
       await page.click('#error');
@@ -77,11 +79,12 @@ for (let i = 0; i < 100; i++) {
       const event2 = getReplayEvent(req2);
       const content2 = getReplayRecordingContent(req2);
 
+      expect(callsToSentry).toBe(4); // 1 error, 3 replay events
+
       expect(event0).toEqual(
         getExpectedReplayEvent({
           contexts: { replay: { error_sample_rate: 1, session_sample_rate: 0 } },
-          // @ts-ignore this is fine
-          error_ids: [errorEventId],
+          error_ids: [errorEventId!],
           replay_type: 'error',
         }),
       );
@@ -105,7 +108,6 @@ for (let i = 0; i < 100; i++) {
       expect(event1).toEqual(
         getExpectedReplayEvent({
           contexts: { replay: { error_sample_rate: 1, session_sample_rate: 0 } },
-          // @ts-ignore this is fine
           replay_type: 'error', // although we're in session mode, we still send 'error' as replay_type
           replay_start_timestamp: undefined,
           segment_id: 1,
@@ -123,7 +125,6 @@ for (let i = 0; i < 100; i++) {
       expect(event2).toEqual(
         getExpectedReplayEvent({
           contexts: { replay: { error_sample_rate: 1, session_sample_rate: 0 } },
-          // @ts-ignore this is fine
           replay_type: 'error',
           replay_start_timestamp: undefined,
           segment_id: 2,

packages/integration-tests/suites/replay/errors/errorsInSession/test.ts

@@ -57,7 +57,6 @@ sentryTest(
       getExpectedReplayEvent({
         replay_start_timestamp: undefined,
         segment_id: 1,
-        // @ts-ignore this is fine
         error_ids: [errorEventId],
         urls: [],
       }),