comments and update test

Author: c298lee

dev-packages/browser-integration-tests/suites/replay/canvas/snapshots/init.js renamed to dev-packages/browser-integration-tests/suites/replay/canvas/manualSnapshots/init.js

@@ -34,7 +34,7 @@ sentryTest('can manually snapshot canvas', async ({ getLocalTestUrl, page, brows
     (window as any).Sentry.getClient().getIntegrationById('ReplayCanvas').snapshot();
   });
 
-  const { incrementalSnapshots:incrementalSnapshotsManual } = getReplayRecordingContent(await reqPromise3);
+  const { incrementalSnapshots: incrementalSnapshotsManual } = getReplayRecordingContent(await reqPromise3);
   expect(incrementalSnapshotsManual).toEqual(
     expect.arrayContaining([
       {

dev-packages/browser-integration-tests/suites/replay/canvas/snapshots/template.html renamed to dev-packages/browser-integration-tests/suites/replay/canvas/manualSnapshots/template.html

@@ -1,14 +1,14 @@
 import { CanvasManager } from '@sentry-internal/rrweb';
 import { convertIntegrationFnToClass } from '@sentry/core';
-import type { CanvasManagerOptions } from '@sentry/replay';
+import type { CanvasManagerInterface, CanvasManagerOptions } from '@sentry/replay';
 import type { IntegrationFn } from '@sentry/types';
 
 interface ReplayCanvasOptions {
   enableManualSnapshot?: boolean;
   quality: 'low' | 'medium' | 'high';
 }
 
-type GetCanvasManager = (options: CanvasManagerOptions) => void;
+type GetCanvasManager = (options: CanvasManagerOptions) => CanvasManagerInterface;
 export interface ReplayCanvasIntegrationOptions {
   enableManualSnapshot?: boolean;
   recordCanvas: true;
@@ -64,7 +64,7 @@ const replayCanvasIntegration = ((options: Partial<ReplayCanvasOptions> = {}) =>
   };
 
   let canvasManagerResolve: (value: CanvasManager) => void;
-  const _canvasManager: Promise<CanvasManager> = new Promise((resolve) => canvasManagerResolve = resolve);
+  const _canvasManager: Promise<CanvasManager> = new Promise(resolve => (canvasManagerResolve = resolve));
 
   return {
     name: INTEGRATION_NAME,
@@ -75,7 +75,11 @@ const replayCanvasIntegration = ((options: Partial<ReplayCanvasOptions> = {}) =>
 
       return {
         recordCanvas: true,
-        getCanvasManager: (options: CanvasManagerOptions) => (canvasManagerResolve(new CanvasManager({ ...options, isManualSnapshot: enableManualSnapshot } ))),
+        getCanvasManager: (options: CanvasManagerOptions) => {
+          const manager = new CanvasManager({ ...options, isManualSnapshot: enableManualSnapshot });
+          canvasManagerResolve(manager);
+          return manager;
+        },
         ...(CANVAS_QUALITY[quality || 'medium'] || CANVAS_QUALITY.medium),
       };
     },

dev-packages/browser-integration-tests/suites/replay/canvas/snapshots/test.ts renamed to dev-packages/browser-integration-tests/suites/replay/canvas/manualSnapshots/test.ts

@@ -17,10 +17,9 @@ it('initializes with default options', () => {
 });
 
 it('initializes with quality option and manual snapshot', () => {
-  const rc = new ReplayCanvas({ enableManualSnapshot: true, quality: 'low' });
+  const rc = new ReplayCanvas({ quality: 'low' });
 
   expect(rc.getOptions()).toEqual({
-    enableManualSnapshot: true,
     recordCanvas: true,
     getCanvasManager: expect.any(Function),
     sampling: {