ref: Make it easier to use stackParser

Author: AbhiPrasad

packages/browser/src/exports.ts

@@ -45,7 +45,8 @@ export {
 
 export { BrowserClient } from './client';
 export {
-  defaultStackParsers,
+  defaultStackParser,
+  defaultStackLineParsers,
   chromeStackParser,
   geckoStackParser,
   opera10StackParser,

packages/browser/src/sdk.ts

@@ -11,15 +11,15 @@ import {
   getGlobalObject,
   logger,
   resolvedSyncPromise,
-  stackParserFromOptions,
+  stackParserFromStackParserOptions,
   supportsFetch,
 } from '@sentry/utils';
 
 import { BrowserClient, BrowserClientOptions, BrowserOptions } from './client';
 import { IS_DEBUG_BUILD } from './flags';
 import { ReportDialogOptions, wrap as internalWrap } from './helpers';
 import { Breadcrumbs, Dedupe, GlobalHandlers, LinkedErrors, TryCatch, UserAgent } from './integrations';
-import { defaultStackParsers } from './stack-parsers';
+import { defaultStackParser } from './stack-parsers';
 import { makeFetchTransport, makeXHRTransport } from './transports';
 
 export const defaultIntegrations = [
@@ -110,7 +110,7 @@ export function init(options: BrowserOptions = {}): void {
 
   const clientOptions: BrowserClientOptions = {
     ...options,
-    stackParser: stackParserFromOptions(options.stackParser || defaultStackParsers),
+    stackParser: stackParserFromStackParserOptions(options.stackParser || defaultStackParser),
     integrations: getIntegrationsToSetup(options),
     transport: options.transport || (supportsFetch() ? makeFetchTransport : makeXHRTransport),
   };

packages/browser/src/stack-parsers.ts

@@ -1,4 +1,5 @@
 import { StackFrame, StackLineParser, StackLineParserFn } from '@sentry/types';
+import { createStackParser } from '@sentry/utils';
 
 // global reference to slice
 const UNKNOWN_FUNCTION = '?';
@@ -130,7 +131,9 @@ const opera11: StackLineParserFn = line => {
 
 export const opera11StackParser: StackLineParser = [OPERA11_PRIORITY, opera11];
 
-export const defaultStackParsers = [chromeStackParser, geckoStackParser, winjsStackParser];
+export const defaultStackLineParsers = [chromeStackParser, geckoStackParser, winjsStackParser];
+
+export const defaultStackParser = createStackParser(...defaultStackLineParsers);
 
 /**
  * Safari web extensions, starting version unknown, can produce "frames-only" stacktraces.

packages/node/src/index.ts

@@ -46,7 +46,7 @@ export { NodeClient } from './client';
 export { defaultIntegrations, init, lastEventId, flush, close, getSentryRelease } from './sdk';
 export { deepReadDirSync } from './utils';
 export { SDK_NAME } from './version';
-export { nodeStackParser } from './stack-parser';
+export { defaultStackParser } from './stack-parser';
 
 import { Integrations as CoreIntegrations } from '@sentry/core';
 import { getMainCarrier } from '@sentry/hub';

packages/node/src/sdk.ts

@@ -1,13 +1,13 @@
 import { getCurrentHub, getIntegrationsToSetup, initAndBind, Integrations as CoreIntegrations } from '@sentry/core';
 import { getMainCarrier, setHubOnCarrier } from '@sentry/hub';
 import { SessionStatus } from '@sentry/types';
-import { getGlobalObject, logger, stackParserFromOptions } from '@sentry/utils';
+import { getGlobalObject, logger, stackParserFromStackParserOptions } from '@sentry/utils';
 import * as domain from 'domain';
 
 import { NodeClient } from './client';
 import { IS_DEBUG_BUILD } from './flags';
 import { Console, ContextLines, Http, LinkedErrors, OnUncaughtException, OnUnhandledRejection } from './integrations';
-import { nodeStackParser } from './stack-parser';
+import { defaultStackParser } from './stack-parser';
 import { makeNodeTransport } from './transports';
 import { NodeClientOptions, NodeOptions } from './types';
 
@@ -130,7 +130,7 @@ export function init(options: NodeOptions = {}): void {
   // TODO(v7): Refactor this to reduce the logic above
   const clientOptions: NodeClientOptions = {
     ...options,
-    stackParser: stackParserFromOptions(options.stackParser || [nodeStackParser]),
+    stackParser: stackParserFromStackParserOptions(options.stackParser || defaultStackParser),
     integrations: getIntegrationsToSetup(options),
     transport: options.transport || makeNodeTransport,
   };

packages/node/src/stack-parser.ts

@@ -1,5 +1,5 @@
 import { StackLineParser, StackLineParserFn } from '@sentry/types';
-import { basename, dirname } from '@sentry/utils';
+import { basename, createStackParser, dirname } from '@sentry/utils';
 
 /** Gets the module */
 function getModule(filename: string | undefined): string | undefined {
@@ -114,4 +114,6 @@ const node: StackLineParserFn = (line: string) => {
   };
 };
 
-export const nodeStackParser: StackLineParser = [90, node];
+export const nodeStackLineParser: StackLineParser = [90, node];
+
+export const defaultStackParser = createStackParser(nodeStackLineParser);

packages/utils/src/stacktrace.ts

@@ -36,7 +36,7 @@ export function createStackParser(...parsers: StackLineParser[]): StackParser {
  *
  * If options contains an array of line parsers, it is converted into a parser
  */
-export function stackParserFromOptions(stackParser: StackParser | StackLineParser[]): StackParser {
+export function stackParserFromStackParserOptions(stackParser: StackParser | StackLineParser[]): StackParser {
   if (Array.isArray(stackParser)) {
     return createStackParser(...stackParser);
   }